[jira] [Commented] (CB-6923) [WP8][cordova-plugin-file] native side does not support relative paths

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070803#comment-14070803 ] 

ASF GitHub Bot commented on CB-6923:
------------------------------------

GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/65

    CB-6923 [WP8] Adding support to handle relative paths

    Added support to resolve relative paths on Windows Phone 8
    
    When the path received is relative, it will combine and obtain a full path before it becomes processed by IsolatedStorageFile and determine if exists.
    
    Two private methods were added to handle this, it won't affect the regular workflow if the path is absolute and it will combine them as usual.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-plugin-file CB-6923

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #65
    
----
commit 4152181c99251360eeddd8ec54795e4b8874d48e
Author: Martin Gonzalez <ma...@gmail.com>
Date:   2014-07-22T20:09:20Z

    CB-6923 Adding support to handle relative paths
    
    Added support to resolve relative paths.
    When the path received is relative, it will combine and obtain a full
    path before it becomes proceced by IsolatedStorageFile and determine if
    exists.
    
    Two private methods were added to handle this, it won't affect the
    regular workflow if the path is absolute and it will combine it as
    usual.

----


> [WP8][cordova-plugin-file] native side does not support relative paths
> ----------------------------------------------------------------------
>
>                 Key: CB-6923
>                 URL: https://issues.apache.org/jira/browse/CB-6923
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File, WP8
>    Affects Versions: 3.5.0
>            Reporter: Martin Gonzalez
>            Assignee: Martin Gonzalez
>              Labels: plugin-file
>             Fix For: 3.6.0
>
>
> The filesystem URIs on WP8, is not able to handle the resolve navigation a parent directory using a relative path, e.g.:
> fileName = ../resolve.file.uri
> Instead is taking ".." as the parent directory not as navigation to the parent directory.
> The filesystem should be able to resolve the path to the parent directory and set root as the ultimate parent directory as well.
> {code}
> ../resolve.file.uri
> {code}
> and
> {code}
> /resolve.file.uri
> {code}
> Should be resolved to the same file, setting the file system root as the last parent directory.
> This:
> {code}
> root.getDirectory(//someDir/someSubDir, function (dir) {
> dir.getFile("../valid.file.txt", .. );
> }, ..);
> {code}
> Should result this: 
> {code}
> "//someDir/valid.file.txt"
> {code}
> Navigation to parent directories should be supported.



--
This message was sent by Atlassian JIRA
(v6.2#6252)