You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/03/26 18:37:35 UTC
[kudu-CR](branch-1.7.x) [delete table-itest] fix flake in TestUnknownTabletsAreNotDeleted
Hello Will Berkeley, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9803
to review the following change.
Change subject: [delete_table-itest] fix flake in TestUnknownTabletsAreNotDeleted
......................................................................
[delete_table-itest] fix flake in TestUnknownTabletsAreNotDeleted
Fixed flake in the DeleteTableITest.TestUnknownTabletsAreNotDeleted.
The flake was easily reproducible under macOS.
The scenario involves removing master's data directory along with the
IPKI information. Once the master re-generates its IPKI system records
and starts using the new TLS server certificate signed by the newly
generated CA private key, the tserver fails to verify the new master's
server certificate using the old CA certificate.
With the RPC authentication set to "optional" and 10ms tserver->master
heartbeat interval, the tserver in most cases was able to establish
a connection to the restarted master before it re-generates its IPKI
records, so no TLS certificate was used for authentication.
Change-Id: Ib6fd439c0ef5fb66b752f7f49175e4c2d818412e
Reviewed-on: http://gerrit.cloudera.org:8080/9722
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
(cherry picked from commit 5d7b68d59ae78560d0997168a27a73c4e5280ecc)
---
M src/kudu/integration-tests/delete_table-itest.cc
1 file changed, 30 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/9803/1
--
To view, visit http://gerrit.cloudera.org:8080/9803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6fd439c0ef5fb66b752f7f49175e4c2d818412e
Gerrit-Change-Number: 9803
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.7.x) [delete table-itest] fix flake in TestUnknownTabletsAreNotDeleted
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9803 )
Change subject: [delete_table-itest] fix flake in TestUnknownTabletsAreNotDeleted
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ib6fd439c0ef5fb66b752f7f49175e4c2d818412e
Gerrit-Change-Number: 9803
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.7.x) [delete table-itest] fix flake in TestUnknownTabletsAreNotDeleted
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9803 )
Change subject: [delete_table-itest] fix flake in TestUnknownTabletsAreNotDeleted
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6fd439c0ef5fb66b752f7f49175e4c2d818412e
Gerrit-Change-Number: 9803
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:54:22 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) [delete table-itest] fix flake in TestUnknownTabletsAreNotDeleted
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9803 )
Change subject: [delete_table-itest] fix flake in TestUnknownTabletsAreNotDeleted
......................................................................
Patch Set 1: Verified+1
Build failure due to the following error:
libtool: Version mismatch error. This is libtool 2.4.2 Debian-2.4.2-1.7ubuntu1, but the definition of this LT_INIT comes from libtool 2.4.6.
Seems like some workspace issues? Anyway, I think it's safe to ignore this because it's unrelated to the change.
--
To view, visit http://gerrit.cloudera.org:8080/9803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6fd439c0ef5fb66b752f7f49175e4c2d818412e
Gerrit-Change-Number: 9803
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 20:06:47 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) [delete table-itest] fix flake in TestUnknownTabletsAreNotDeleted
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9803 )
Change subject: [delete_table-itest] fix flake in TestUnknownTabletsAreNotDeleted
......................................................................
[delete_table-itest] fix flake in TestUnknownTabletsAreNotDeleted
Fixed flake in the DeleteTableITest.TestUnknownTabletsAreNotDeleted.
The flake was easily reproducible under macOS.
The scenario involves removing master's data directory along with the
IPKI information. Once the master re-generates its IPKI system records
and starts using the new TLS server certificate signed by the newly
generated CA private key, the tserver fails to verify the new master's
server certificate using the old CA certificate.
With the RPC authentication set to "optional" and 10ms tserver->master
heartbeat interval, the tserver in most cases was able to establish
a connection to the restarted master before it re-generates its IPKI
records, so no TLS certificate was used for authentication.
Change-Id: Ib6fd439c0ef5fb66b752f7f49175e4c2d818412e
Reviewed-on: http://gerrit.cloudera.org:8080/9722
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
(cherry picked from commit 5d7b68d59ae78560d0997168a27a73c4e5280ecc)
Reviewed-on: http://gerrit.cloudera.org:8080/9803
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/delete_table-itest.cc
1 file changed, 30 insertions(+), 18 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6fd439c0ef5fb66b752f7f49175e4c2d818412e
Gerrit-Change-Number: 9803
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>