You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by icexelloss <gi...@git.apache.org> on 2018/02/02 21:58:05 UTC
[GitHub] spark pull request #20489: [MINOR][TEST] Fix test name for scalar pandas UDF...
GitHub user icexelloss opened a pull request:
https://github.com/apache/spark/pull/20489
[MINOR][TEST] Fix test name for scalar pandas UDF tests
## What changes were proposed in this pull request?
In https://github.com/apache/spark/commit/b2ce17b4c9fea58140a57ca1846b2689b15c0d61, I mistakenly renamed `VectorizedUDFTests` to `ScalarPandasUDF. This PR fixes the mistake.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/icexelloss/spark fix-scalar-udf-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20489.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20489
----
commit 52498c0d9d46f931e4efbeabcb5a51ca404eed95
Author: Li Jin <ic...@...>
Date: 2018-02-02T21:51:46Z
Fix name of ScalarPandasUDFTests
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20489
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20489
**[Test build #87008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87008/testReport)** for PR 20489 at commit [`52498c0`](https://github.com/apache/spark/commit/52498c0d9d46f931e4efbeabcb5a51ca404eed95).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20489
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20489
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/632/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20489
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/544/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20489
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20489
gentle ping @icexelloss
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20489
Let's fix `GroupbyApplyPandasUDFTests` -> `GroupedMapPandasUDFTests` and `GroupbyAggPandasUDFTests` -> `GroupedAggPandasUDFTests` too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20489
**[Test build #87116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87116/testReport)** for PR 20489 at commit [`442e2a1`](https://github.com/apache/spark/commit/442e2a16944ed71e78c8a258f48c071c5f283ce0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20489
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20489
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87008/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20489
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87116/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix test name for scalar pandas UDF tests
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/20489
cc @HyukjinKwon
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20489
**[Test build #87116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87116/testReport)** for PR 20489 at commit [`442e2a1`](https://github.com/apache/spark/commit/442e2a16944ed71e78c8a258f48c071c5f283ce0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class GroupedMapPandasUDFTests(ReusedSQLTestCase):`
* `class GroupedAggPandasUDFTests(ReusedSQLTestCase):`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by icexelloss <gi...@git.apache.org>.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/20489
Sorry I was away for a few days. Should be good now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20489
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for Pandas UDF tests
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20489
Thanks! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20489: [MINOR][TEST] Fix class name for ScalarPandasUDFTests
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20489
**[Test build #87008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87008/testReport)** for PR 20489 at commit [`52498c0`](https://github.com/apache/spark/commit/52498c0d9d46f931e4efbeabcb5a51ca404eed95).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class ScalarPandasUDFTests(ReusedSQLTestCase):`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org