[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8418: Flask App factory PR #1

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #8418: Flask App factory PR #1
URL: https://github.com/apache/incubator-superset/pull/8418#discussion_r344008838
 
 

 ##########
 File path: setup.py
 ##########
 @@ -110,6 +110,7 @@ def get_git_sha():
     extras_require={
         "bigquery": ["pybigquery>=0.4.10", "pandas_gbq>=0.10.0"],
         "cors": ["flask-cors>=2.0.0"],
+        "flask-testing": ["Flask-Testing==0.7.1"],
 
 Review comment:
   Nit. Can we lowercase this like the other packages. Package names are case insensitive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org