You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/06 09:42:53 UTC
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #970: MINIFICPP-1396 Create FetchS3Object processor
adamdebreceni commented on a change in pull request #970:
URL: https://github.com/apache/nifi-minifi-cpp/pull/970#discussion_r552469881
##########
File path: extensions/aws/s3/S3WrapperBase.cpp
##########
@@ -68,13 +75,13 @@ void S3WrapperBase::setCannedAcl(Aws::S3::Model::PutObjectRequest& request, cons
request.SetACL(CANNED_ACL_MAP.at(canned_acl));
}
-std::string S3WrapperBase::getExpiryDate(const std::string& expiration) {
+std::pair<std::string, std::string> S3WrapperBase::getExpirationPair(const std::string& expiration) {
static const std::regex expr = std::regex("expiry-date=\"(.*)\", rule-id=\"(.*)\"");
Review comment:
shouldn't we use the `Regex` class defined in `RegexUtils.h`? (that contains some "magic" for `<GCC 4.9`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org