[GitHub] [spark] ulysses-you commented on pull request #37641: [SPARK-40201][SQL][TESTS] Improve v1 write test coverage

[GitBox <gi...@apache.org>]

ulysses-you commented on PR #37641:
URL: https://github.com/apache/spark/pull/37641#issuecomment-1272190902

   @allisonwang-db thank you for review. There are two cases that the ordering does not match:
   - the added sort will be removed in Optimizer, e.g. the plan has one row or the dynamic partition column is foldable
   - the added sort ordering expression has an alias which will be replaced by `AliasAwareOutputExpression`, then the ordering does not match
   
   I have a pr for case 1 about foldable see https://github.com/apache/spark/pull/37831, but need to simplify a bit more. I think pr https://github.com/apache/spark/pull/37525 can save the case 2, although I do not looked it deeply.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org