You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2024/07/15 07:29:04 UTC
[I] Support time series data structure and commands like Redis [kvrocks]
PragmaTwice opened a new issue, #2421:
URL: https://github.com/apache/kvrocks/issues/2421
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
### Motivation
RedisTimeSeries is a redis module used to operate and query time series data, giving redis basic time series database capabilities.
As Apache Kvrocks is characterized by being compatible with the Redis protocol and commands, we also hope to provide temporal data processing capabilities that are compatible with RedisTimeSeries.
This task is to implement the time series data structure and its commands on Kvrocks. Note: Since Kvrocks is an on-disk database based on RocksDB, the implementation will be quite different from Redis.
https://redis.io/docs/data-types/timeseries/
https://kvrocks.apache.org/community/data-structure-on-rocksdb
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "Beihao-Zhou (via GitHub)" <gi...@apache.org>.
Beihao-Zhou commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2237859014
> Hi @Beihao-Zhou ,
>
> I have read your proposal and have one concern on `Secondary Keys & Values > Label Index`. The key in proposal is in `[label_key]|[label_value]|[key]` format. It may need a full iteration scan when purging a key. Making key as the first prefix part like `[key]|[label_key]|[label_value]` may reduce the complexity on cleanup.
>
> I'm very interested in time series topic and willing to make some contribution in this feature. 😄
>
> Best Regards, Edward
The secondary indexing I proposed is mainly for`MRANGE`, which will do some filtering based on label. So for this command, the secondary index is pretty similar to tag field index in KQIR (#2329). If the query asks for the TS range for a particular key, then I think searching for the primary key is enough?
Let me know if I misunderstand your question. Also feel free to use any idea from the proposal! <3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "fukua95 (via GitHub)" <gi...@apache.org>.
fukua95 commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2624623337
> [@fukua95](https://github.com/fukua95) Thanks for looking into this issue! Let me double check if anyone is working on this. Hi [@jonathanc-n](https://github.com/jonathanc-n), just wondering if you're still working on the issue?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "fukua95 (via GitHub)" <gi...@apache.org>.
fukua95 commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2624592410
Can I be assigned this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "Beihao-Zhou (via GitHub)" <gi...@apache.org>.
Beihao-Zhou commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2624603269
@fukua95 Thanks for looking into this issue! Let me double check if anyone is working on this.
Hi @jonathanc-n, just wondering if you're still working on the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "LindaSummer (via GitHub)" <gi...@apache.org>.
LindaSummer commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2241168168
> > Hi @Beihao-Zhou ,
> > I have read your proposal and have one concern on `Secondary Keys & Values > Label Index`. The key in proposal is in `[label_key]|[label_value]|[key]` format. It may need a full iteration scan when purging a key. Making key as the first prefix part like `[key]|[label_key]|[label_value]` may reduce the complexity on cleanup.
> > I'm very interested in time series topic and willing to make some contribution in this feature. 😄
> > Best Regards, Edward
>
> The secondary indexing I proposed is mainly for`MRANGE`, which will do some filtering based on label. So for this command, the secondary index is pretty similar to tag field index in KQIR (#2329). If a key is purged, then I think constructing the corresponding secondary index key and deleting it would be enough?
>
> Let me know if I misunderstand your question. Also feel free to use any idea from the proposal! <3
Hi @Beihao-Zhou ,
Thanks for your patience and response!
I have read the KQIR encoding design and get your point.
I will research more about the Redis's implementation.
Please let me know if we have any new idea on this topic. 😊
Best Regards,
Edward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "Beihao-Zhou (via GitHub)" <gi...@apache.org>.
Beihao-Zhou commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2229333141
Since this was a GSOC project, I drafted a [TS data structure proposal](https://beihao-rebecca.notion.site/TimeSeries-Proposal-6c5d2f9bc0624a50a209cb8f517109a8) before. Hope this can help give a good starting point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2624687444
@fukua95 I am not working on this issue anymore, feel free to take it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2803784973
I'm publishing this task as an OSPP project : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support time series data structure and commands like Redis [kvrocks]
Posted by "LindaSummer (via GitHub)" <gi...@apache.org>.
LindaSummer commented on issue #2421:
URL: https://github.com/apache/kvrocks/issues/2421#issuecomment-2235933146
Hi @Beihao-Zhou ,
I have read your proposal and have one concern on `Secondary Keys & Values > Label Index`.
The key in proposal is in `[label_key]|[label_value]|[key]` format.
It may need an full iteration scan when purging a key.
Making key as the first prefix part like `[key][label_key]|[label_value]` may reduce the complexity on cleanup.
I'm very interested in time series topic and willing to make some contribution in this feature. 😄
Best Regards,
Edward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org