[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #10070: [enhancement] Change array offset type from UInt32 to UInt64

[GitBox <gi...@apache.org>]

cambyzju commented on code in PR #10070:
URL: https://github.com/apache/incubator-doris/pull/10070#discussion_r897790755


##########
be/src/runtime/collection_value.h:
##########
@@ -123,21 +123,21 @@ class CollectionValue {
     const bool* null_signs() const { return _null_signs; }
     void* mutable_data() { return _data; }
     bool* mutable_null_signs() { return _null_signs; }
-    void set_length(uint32_t length) { _length = length; }
+    void set_length(int64_t length) { _length = length; }
     void set_has_null(bool has_null) { _has_null = has_null; }
     void set_data(void* data) { _data = data; }
     void set_null_signs(bool* null_signs) { _null_signs = null_signs; }
 
 private:
     using AllocateMemFunc = std::function<uint8_t*(size_t size)>;
     static Status init_collection(CollectionValue* value, const AllocateMemFunc& allocate,
-                                  uint32_t size, PrimitiveType child_type);
+                                  int64_t size, PrimitiveType child_type);
     ArrayIterator internal_iterator(PrimitiveType child_type) const;
 
 private:
     // child column data
     void* _data;
-    uint32_t _length;
+    int64_t _length;

Review Comment:
   done



##########
be/src/runtime/collection_value.h:
##########
@@ -160,7 +160,7 @@ class ArrayIterator {
         }
         return false;
     }
-    bool seek(uint32_t n) const {
+    bool seek(int64_t n) const {

Review Comment:
   u64



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org