You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/07 00:36:24 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1200: Remove "undef __KERNEL__" from userled and button low half driver implmentation

Ouss4 commented on pull request #1200:
URL: https://github.com/apache/incubator-nuttx/pull/1200#issuecomment-640137366


   The change looks good, however having an init function return a value (other than an error code) seems weird.  I skimmed the code base to find a similar case but couldn't find any, do you have one in mind?
   At the same time I don't know if introducing a new function is any better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org