Re: [PR] refactor(go-client): refactor admin APIs for meta by reflection [incubator-pegasus]

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #1929:
URL: https://github.com/apache/incubator-pegasus/pull/1929#discussion_r1515611197


##########
go-client/admin/client.go:
##########
@@ -33,51 +34,101 @@ import (
 // Client provides the administration API to a specific cluster.
 // Remember only the superusers configured to the cluster have the admin priviledges.
 type Client interface {
-	CreateTable(ctx context.Context, tableName string, partitionCount int, successIfExist_optional ...bool) error
+	Close() error
 
-	DropTable(ctx context.Context, tableName string) error
+	GetTimeout() time.Duration
+	SetTimeout(timeout time.Duration)
 
-	ListTables(ctx context.Context) ([]*TableInfo, error)
-}
+	CreateTable(tableName string, partitionCount int32, replicaCount int32, envs map[string]string, maxWaitSeconds int32, successIfExistOptional ...bool) (int32, error)

Review Comment:
   It would be better to describe what does `maxWaitSeconds`, I doubt if there is any difference with `timeout`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org