You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/26 08:59:20 UTC
[GitHub] [rocketmq-dashboard] Oliverwqcwrw opened a new pull request, #107: Add asynchronous appender to avoid main thread is blocking
Oliverwqcwrw opened a new pull request, #107:
URL: https://github.com/apache/rocketmq-dashboard/pull/107
## What is the purpose of the change
Add asynchronous appender to avoid main thread is blocking
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] Oliverwqcwrw closed pull request #107: Add asynchronous appender to avoid main thread is blocking
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw closed pull request #107: Add asynchronous appender to avoid main thread is blocking
URL: https://github.com/apache/rocketmq-dashboard/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] codecov-commenter commented on pull request #107: Add asynchronous appender to avoid main thread is blocking
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #107:
URL: https://github.com/apache/rocketmq-dashboard/pull/107#issuecomment-1195357744
# [Codecov](https://codecov.io/gh/apache/rocketmq-dashboard/pull/107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#107](https://codecov.io/gh/apache/rocketmq-dashboard/pull/107?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dacee68) into [master](https://codecov.io/gh/apache/rocketmq-dashboard/commit/63d9da7429177914b73c077da807506240a96ef4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63d9da7) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #107 +/- ##
=========================================
Coverage 76.92% 76.92%
Complexity 822 822
=========================================
Files 91 91
Lines 2847 2847
Branches 282 282
=========================================
Hits 2190 2190
Misses 500 500
Partials 157 157
```
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org