Re: [PR] feat(dashboard): "embed code" option on dashboard share tab [superset]

["EnxDev (via GitHub)" <gi...@apache.org>]

EnxDev commented on code in PR #33163:
URL: https://github.com/apache/superset/pull/33163#discussion_r2533570867


##########
superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx:
##########
@@ -34,6 +36,8 @@ interface ShareMenuItemProps extends ComponentProps<typeof Menu.SubMenu> {
   addSuccessToast: Function;
   dashboardId: string | number;
   dashboardComponentId?: string;
+  latestQueryFormData?: object;

Review Comment:
   ```suggestion
     latestQueryFormData?: LatestQueryFormData;
   ```



##########
superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx:
##########
@@ -109,6 +119,27 @@ const ShareMenuItems = (props: ShareMenuItemProps) => {
       <Menu.Item key={MenuKeys.ShareByEmail} onClick={() => onShareByEmail()}>
         {emailMenuItemTitle}
       </Menu.Item>
+      {isEmbedCodeEnabled && sliceExists && (
+        <Menu.Item key="embed_code">

Review Comment:
   ```suggestion
           <Menu.Item key={MenuKeys.EMBED_CODE}>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org