You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/12/08 21:53:08 UTC
[GitHub] incubator-beam pull request #1556: [BEAM-23] Refactors to support key-preser...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1556
[BEAM-23] Refactors to support key-preserving in direct runner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @tgroh
I've peeled these commits off since they make some sense on their own. The intent is that just tweaking the logic in `KeyedPValueTrackingVisitor` (in potentially hacky ways :-) we can start to allow key preservation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam KeyedPValueTrackingVisitor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1556
----
commit d350b3d3708b83508d3e1df56638e0104ec28b83
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-12-08T19:49:15Z
Add some key-preserving to KeyedPValueTrackingVisitor
commit 93e3af2dba38dea4a708ce4d85d29cf74e029de4
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-12-08T21:28:44Z
Move responsibility for knowing about keyedness into EvaluationContext
This will allow transform evaluators to inquire about whether
various collections are keyed.
commit 1c756f85c8a04422d28e6063ba4072dd4fb0ea73
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-12-08T19:44:48Z
Propagate key through ParDo if DoFn is key-preserving
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1556: [BEAM-23] Refactors to support key-preser...
Posted by kennknowles <gi...@git.apache.org>.
Github user kennknowles closed the pull request at:
https://github.com/apache/incubator-beam/pull/1556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---