[GitHub] [lucene-solr] jaisonbi edited a comment on pull request #2302: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted D…

[GitBox <gi...@apache.org>]

jaisonbi edited a comment on pull request #2302:
URL: https://github.com/apache/lucene-solr/pull/2302#issuecomment-773733335


   > It looks to me as if when compression is not enabled, the index format is unchanged, so this should be backwards-compatible. Is that correct? 
   
   Correct.
   
   And if terms-dict compression is enabled, it is only for high-cardinality fields...so normally, some fields kept un-compressed even if terms-dict compression is enabled...The compression state is stored in *dvm file per field, so during reading, we know which fields need to be decompressed..
   
   >  I think we should have a test that proves that, but perhaps there is already a back-compat test that covers this case? 
   
   I already added one test to prove that merge works fine if both old segments(before this improvement) and the new segments involved...Please see TestDocValuesCompression#testMergeWithUncompressedSegment...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org