You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Vishalup29 (via GitHub)" <gi...@apache.org> on 2025/11/30 06:30:25 UTC
[PR] Snowflake: Support passing OAuth scope parameter in client_credentials flow [airflow]
Vishalup29 opened a new pull request, #58863:
URL: https://github.com/apache/airflow/pull/58863
## Description
This PR adds support for passing an optional OAuth `scope` parameter when using the
`client_credentials` grant type in `SnowflakeHook.get_oauth_token`.
Many identity providers (Okta, Auth0, Azure AD, corporate IdPs) require or recommend including a scope
in client-credential OAuth exchanges. Currently, Airflow cannot send a scope value, forcing users to
apply custom patches or weaken their IdP requirements.
This PR introduces an optional extra field on the Snowflake connection:
extra: {"oauth_scope": "your-scope-value"}
less
Copy code
When present and the `grant_type` is `client_credentials`, the hook will send:
scope=<value>
markdown
Copy code
in the POST body to the token endpoint.
If no scope is provided, the existing behavior is unchanged.
## Tests
This PR updates the OAuth unit tests to validate:
- Scope is not included for refresh token grant (existing behavior unchanged)
- Scope *is* included when:
- `grant_type=client_credentials`
- `oauth_scope` is provided
- Scope is omitted when the field is empty or not provided
- Existing OAuth tests continue to pass untouched
## Cross-provider compatibility
This matches patterns already used in Azure OAuth (`azure_oauth_scope`).
## Related Issue
Closes #58815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Snowflake: Support passing OAuth scope parameter in client_credentials flow [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #58863: Snowflake: Support passing OAuth scope parameter in client_credentials flow
URL: https://github.com/apache/airflow/pull/58863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Snowflake: Support passing OAuth scope parameter in client_credentials flow [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58863:
URL: https://github.com/apache/airflow/pull/58863#issuecomment-3599275705
Already merged in https://github.com/apache/airflow/issues/58815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Snowflake: Support passing OAuth scope parameter in client_credentials flow [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #58863:
URL: https://github.com/apache/airflow/pull/58863#issuecomment-3592275118
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org