[GitHub] pengzhao-intel commented on a change in pull request #13952: Fix MXNet R package build

[GitBox <gi...@apache.org>]

pengzhao-intel commented on a change in pull request #13952: Fix MXNet R package build
URL: https://github.com/apache/incubator-mxnet/pull/13952#discussion_r252301437
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -902,6 +902,22 @@ unittest_ubuntu_cpu_R() {
     make rpkgtest R_LIBS=/tmp/r-site-library
 }
 
+unittest_ubuntu_minimal_R() {
+    set -ex
+    mkdir -p /tmp/r-site-library
+    # build R packages in parallel
+    mkdir -p ~/.R/
+    build_ccache_wrappers
+    echo  "MAKEFLAGS = -j"$(nproc) > ~/.R/Makevars
+    # make -j not supported
+    make rpkg                           \
+        USE_BLAS=openblas               \
+        R_LIBS=/tmp/r-site-library
+
+    R CMD INSTALL --library=/tmp/r-site-library R-package
+    R_LIBS=/tmp/r-site-library Rscript -e "library(mxnet); as.array(mx.nd.ones(c(2,3)))"
 
 Review comment:
   Could we add a more meaningful test, like convolution, FC or relu which will hit the real MKLDNN calculation?
   We need to guarantee R can execute at least in the CI.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services