You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sergeyuttsel (via GitHub)" <gi...@apache.org> on 2023/05/11 12:35:42 UTC
[GitHub] [ignite-3] sergeyuttsel opened a new pull request, #2063: IGNITE-19427
sergeyuttsel opened a new pull request, #2063:
URL: https://github.com/apache/ignite-3/pull/2063
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc merged pull request #2063: IGNITE-19427 dataNodesAutoAdjustScaleUp is immediate for new distribution zones.
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc merged PR #2063:
URL: https://github.com/apache/ignite-3/pull/2063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2063: IGNITE-19427 dataNodesAutoAdjustScaleUp is immediate for new distribution zones.
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #2063:
URL: https://github.com/apache/ignite-3/pull/2063#discussion_r1191278984
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerTest.java:
##########
@@ -247,12 +248,6 @@ private void testUpdateZone(String zoneName) throws Exception {
assertEquals(INFINITE_TIMER_VALUE, zone.dataNodesAutoAdjustScaleDown().value(), "dataNodesAutoAdjustScaleDown is wrong.");
assertEquals(100, zone.dataNodesAutoAdjust().value(), "dataNodesAutoAdjust is wrong.");
- assertNotNull(zone, "Zone was not created.");
Review Comment:
Is it just a duplication of lines 244-249?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2063: IGNITE-19427 dataNodesAutoAdjustScaleUp is immediate for new distribution zones.
Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel commented on code in PR #2063:
URL: https://github.com/apache/ignite-3/pull/2063#discussion_r1191286654
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerTest.java:
##########
@@ -247,12 +248,6 @@ private void testUpdateZone(String zoneName) throws Exception {
assertEquals(INFINITE_TIMER_VALUE, zone.dataNodesAutoAdjustScaleDown().value(), "dataNodesAutoAdjustScaleDown is wrong.");
assertEquals(100, zone.dataNodesAutoAdjust().value(), "dataNodesAutoAdjust is wrong.");
- assertNotNull(zone, "Zone was not created.");
Review Comment:
Yes. Double check :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2063: IGNITE-19427 dataNodesAutoAdjustScaleUp is immediate for new distribution zones.
Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel commented on code in PR #2063:
URL: https://github.com/apache/ignite-3/pull/2063#discussion_r1191307525
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -370,10 +370,13 @@ public CompletableFuture<Integer> createZone(DistributionZoneConfigurationParame
}
if (distributionZoneCfg.dataNodesAutoAdjustScaleUp() == null) {
- zoneChange.changeDataNodesAutoAdjustScaleUp(INFINITE_TIMER_VALUE);
+ if (distributionZoneCfg.dataNodesAutoAdjust() == null) {
+ zoneChange.changeDataNodesAutoAdjustScaleUp(IMMEDIATE_TIMER_VALUE);
Review Comment:
Thanks. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2063: IGNITE-19427 dataNodesAutoAdjustScaleUp is immediate for new distribution zones.
Posted by "sanpwc (via GitHub)" <gi...@apache.org>.
sanpwc commented on code in PR #2063:
URL: https://github.com/apache/ignite-3/pull/2063#discussion_r1191262539
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -370,10 +370,13 @@ public CompletableFuture<Integer> createZone(DistributionZoneConfigurationParame
}
if (distributionZoneCfg.dataNodesAutoAdjustScaleUp() == null) {
- zoneChange.changeDataNodesAutoAdjustScaleUp(INFINITE_TIMER_VALUE);
+ if (distributionZoneCfg.dataNodesAutoAdjust() == null) {
+ zoneChange.changeDataNodesAutoAdjustScaleUp(IMMEDIATE_TIMER_VALUE);
Review Comment:
Do we really need it? Seems that we shouldn't manually set default value specified in DistributionZoneConfigurationSchema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org