[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #449: [SUREFIRE-1987] Refactor ProviderDetector

[GitBox <gi...@apache.org>]

Tibor17 commented on a change in pull request #449:
URL: https://github.com/apache/maven-surefire/pull/449#discussion_r793083484



##########
File path: maven-surefire-common/src/main/java/org/apache/maven/surefire/providerapi/ProviderDetector.java
##########
@@ -90,15 +95,13 @@
         }
     }
 
-    private ProviderInfo findByName( String providerClassName, ProviderInfo... wellKnownProviders )
+    @Nonnull
+    private ProviderInfo findByName( String providerClassName,
+                                     ConfigurableProviderInfo dynamicProvider, ProviderInfo... wellKnownProviders )
     {
-        for ( ProviderInfo wellKnownProvider : wellKnownProviders )
-        {
-            if ( wellKnownProvider.getProviderName().equals( providerClassName ) )
-            {
-                return wellKnownProvider;
-            }
-        }
-        return null;
+        return Arrays.stream( wellKnownProviders )
+            .filter( p -> p.getProviderName().equals( providerClassName ) )
+            .findFirst()
+            .orElseGet( () -> dynamicProvider.instantiate( providerClassName ) );

Review comment:
       `.orElseGet( () -> dynamicProvider.instantiate( providerClassName ) )` should be after the line 57.
   This method is about finding something only.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org