You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2017/03/16 12:51:36 UTC

[GitHub] couchdb-fauxton pull request #802: COUCHDB-3224: Fixed database name encodin...

Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/802#discussion_r106408017
  
    --- Diff: app/addons/databases/actions.js ---
    @@ -155,7 +155,7 @@ export default {
               type: 'success',
               clear: true
             });
    -        var route = FauxtonAPI.urls('allDocs', 'app', app.utils.safeURLName(databaseName), '?limit=' + Resources.DocLimit);
    +        var route = FauxtonAPI.urls('allDocs', 'app', encodeURIComponent(databaseName), '?limit=' + Resources.DocLimit);
    --- End diff --
    
    Could you rather use this function https://github.com/apache/couchdb-fauxton/blob/master/app/addons/documents/base.js#L40 and then you don't need to encodeURIComponent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---