[jira] [Comment Edited] (TS-2148) handle_cache_operation_on_forward_server_response ignores value of api_server_response_no_store

["Alan M. Carroll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748942#comment-13748942 ] 

Alan M. Carroll edited comment on TS-2148 at 8/23/13 8:24 PM:
--------------------------------------------------------------

After much chatting, the consensus is that this will not be a problem because HttpTransact::State is a member of HttpSM, and it is before HttpSM::history, which means it is zero'd when the state is reused. So everything is OK.
                
      was (Author: amc):
    After much chatting, the consensus is that this will not be a problem if HttpTransact::State::destroy is updated to clear the flag.
                  
> handle_cache_operation_on_forward_server_response ignores value of api_server_response_no_store
> -----------------------------------------------------------------------------------------------
>
>                 Key: TS-2148
>                 URL: https://issues.apache.org/jira/browse/TS-2148
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>            Reporter: Corey Cossentino
>         Attachments: ts2148_response_no_store.patch
>
>
> In the function {{HttpTransact::handle_cache_operation_on_forward_server_response}} there is a line that checks the value of {{s->api_server_response_no_store}} (line 4162 in HttpTransact.cc). This value will never be true, however, because {{is_response_cacheable}} is called before this check (on line 3934) and sets this value to false (on line 6104).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira