You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Uwe Schindler (Jira)" <ji...@apache.org> on 2021/05/26 09:10:00 UTC

[jira] [Created] (LUCENE-9977) Gradle's RAT task has missing inputs, so it can't figure out when to run

Uwe Schindler created LUCENE-9977:
-------------------------------------

             Summary: Gradle's RAT task has missing inputs, so it can't figure out when to run
                 Key: LUCENE-9977
                 URL: https://issues.apache.org/jira/browse/LUCENE-9977
             Project: Lucene - Core
          Issue Type: Task
    Affects Versions: main (9.0)
            Reporter: Uwe Schindler
            Assignee: Dawid Weiss


This also affects Solr!

[~romseygeek] wrote:
{quote}
There’s a subject line I never thought I’d type :)

Firstly: can I say how much I appreciate all the work that’s gone into the gradle build? I’ve been doing lots of small PRs for the spans-to-queries work and being able to run checks multiple times in an extremely efficient manner has been a life saver.  Massive thanks to Dawid, and also to Robert for all the work on speeding up tests.

I think may have found a bug in the input configuration for our license header checks.  Thanks to the new build, I have been running `./gradlew check` before pushing code, but it has let through files with missing headers a few times, which were subsequently caught by the GitHub action running on the PR.

So I tried the following:
- start a new git branch
- run ./gradlew rat -> everything should pass
- edit one of the files to remove the license header
- run ./gradlew rat -> still passes!
- run ./gradlew clean
- run ./gradlew rat -> now I get an error

This looks to me like the fileset that the rat task is looking at is not set up correctly, but I don’t know enough gradle to actually work out what is wrong and what the fix should be.
{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org