You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/28 17:38:52 UTC
[GitHub] [dolphinscheduler] sneh-wha opened a new pull request, #10660: Doc change datasource
sneh-wha opened a new pull request, #10660:
URL: https://github.com/apache/dolphinscheduler/pull/10660
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10660: Doc change datasource
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10660:
URL: https://github.com/apache/dolphinscheduler/pull/10660#discussion_r909256501
##########
docs/docs/en/guide/parameter/built-in.md:
##########
@@ -2,47 +2,33 @@
## Basic Built-in Parameter
-<table>
- <tr><th>Variable</th><th>Declaration Method</th><th>Meaning</th></tr>
- <tr>
- <td>system.biz.date</td>
- <td>${system.biz.date}</td>
- <td>The day before the schedule time of the daily scheduling instance, the format is yyyyMMdd</td>
- </tr>
- <tr>
- <td>system.biz.curdate</td>
- <td>${system.biz.curdate}</td>
- <td>The schedule time of the daily scheduling instance, the format is yyyyMMdd</td>
- </tr>
- <tr>
- <td>system.datetime</td>
- <td>${system.datetime}</td>
- <td>The schedule time of the daily scheduling instance, the format is yyyyMMddHHmmss</td>
- </tr>
-</table>
+| Variable | Declaration Method | Meaning |
+| ---- | ---- | -----------------------------|
+| system.biz.date | ${system.biz.date} | The day before the schedule time of the daily scheduling instance, the format is yyyyMMdd |
+| system.biz.curdate | ${system.biz.curdate} | The schedule time of the daily scheduling instance, the format is yyyyMMdd |
+| system.datetime | ${system.datetime} | The schedule time of the daily scheduling instance, the format is yyyyMMddHHmmss |
Review Comment:
the parameter doc already change in #10659 , you should remvoe those change in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10660: Doc change datasource
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10660:
URL: https://github.com/apache/dolphinscheduler/pull/10660#discussion_r909271224
##########
docs/docs/en/guide/datasource/redshift.md:
##########
@@ -0,0 +1,20 @@
+# Amazon Redshift
+
+
Review Comment:
```suggestion
```
##########
docs/docs/en/guide/datasource/sql-server.md:
##########
@@ -0,0 +1,22 @@
+# SQL Server
+
+
Review Comment:
```suggestion
```
##########
docs/docs/en/guide/datasource/oracle.md:
##########
@@ -0,0 +1,20 @@
+# Oracle
+
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10660: Doc change datasource
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10660:
URL: https://github.com/apache/dolphinscheduler/pull/10660#discussion_r909227962
##########
docs/docs/en/guide/datasource/redshift.md:
##########
@@ -0,0 +1,22 @@
+# Amazon Redshift
+
+
+
+## Datasource Parameters
+
+| **Datasource** | **Description** |
+| --- | --- |
+| Datasource | Select Redshift. |
+| Datasource Name | Enter the name of the datasource. |
+| Description | Enter a description of the datasource. |
+| IP/Host Name | Enter the Redshift service IP. |
+| Port | Enter the Redshift service port. |
+| Username | Set the username for Redshift connection. |
+| Password | Set the password for Redshift connection. |
+| Database Name | Enter the database name of the Redshift connection. |
+| jdbc connect parameters | Parameter settings for Redshift connection, in JSON format. |
+
+
Review Comment:
```suggestion
```
remove the unnessary blank line
##########
docs/docs/en/guide/datasource/oracle.md:
##########
@@ -0,0 +1,22 @@
+# Oracle
+
+
+
+## Datasource Parameters
+
+| **Datasource** | **Description** |
+| --- | --- |
+| Datasource | Select Oracle. |
+| Datasource Name | Enter the name of the datasource. |
+| Description | Enter a description of the datasource. |
+| IP/Host Name | Enter the Oracle service IP. |
+| Port | Enter the Oracle service port. |
+| Username | Set the username for Oracle connection. |
+| Password | Set the password for Oracle connection. |
+| Database Name | Enter the database name of the Oracle connection. |
+| jdbc connect parameters | Parameter settings for Oracle connection, in JSON format. |
+
+## Native Supported
+
+
Review Comment:
remove the unnessary blank line
##########
docs/docs/en/guide/datasource/oracle.md:
##########
@@ -0,0 +1,22 @@
+# Oracle
+
+
+
+## Datasource Parameters
+
+| **Datasource** | **Description** |
+| --- | --- |
+| Datasource | Select Oracle. |
+| Datasource Name | Enter the name of the datasource. |
+| Description | Enter a description of the datasource. |
+| IP/Host Name | Enter the Oracle service IP. |
+| Port | Enter the Oracle service port. |
+| Username | Set the username for Oracle connection. |
+| Password | Set the password for Oracle connection. |
+| Database Name | Enter the database name of the Oracle connection. |
+| jdbc connect parameters | Parameter settings for Oracle connection, in JSON format. |
+
+## Native Supported
+
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10660: Doc change datasource
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10660:
URL: https://github.com/apache/dolphinscheduler/pull/10660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org