[GitHub] [dubbo] changfubai commented on a change in pull request #8844: Optimize some UnitTest case cost time sharply

[GitBox <gi...@apache.org>]

changfubai commented on a change in pull request #8844:
URL: https://github.com/apache/dubbo/pull/8844#discussion_r713536594



##########
File path: dubbo-remoting/dubbo-remoting-zookeeper-curator5/src/test/java/org/apache/dubbo/remoting/zookeeper/curator5/Curator5ZookeeperClientTest.java
##########
@@ -95,20 +97,11 @@ public void process(WatchedEvent watchedEvent) throws Exception {
     @Test
     public void testWithInvalidServer() {
         Assertions.assertThrows(IllegalStateException.class, () -> {
-            curatorClient = new Curator5ZookeeperClient(URL.valueOf("zookeeper://127.0.0.1:1/service"));
+            curatorClient = new Curator5ZookeeperClient(URL.valueOf("zookeeper://127.0.0.1:1/service?timeout=500"));

Review comment:
       请问加timeout会不会增加ut不过的频繁程度呀？zk稍微慢一点，ut就过不了了，到时候提代码太痛苦了~.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org