[GitHub] [zeppelin] jongyoul commented on pull request #4223: [WIP] [ZEPPELIN-5518] Adopt JSR356 for Websocket

[GitBox <gi...@apache.org>]

jongyoul commented on pull request #4223:
URL: https://github.com/apache/zeppelin/pull/4223#issuecomment-921904083


   Yes, it could be but, wothout it, test would be passed. WDYT?
   
   2021년 9월 18일 (토) 00:52, Jeff Zhang ***@***.***>님이 작성:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > zeppelin-jupyter/src/main/java/org/apache/zeppelin/jupyter/JupyterUtil.java
   > <https://github.com/apache/zeppelin/pull/4223#discussion_r711171057>:
   >
   > > @@ -78,7 +78,7 @@ public JupyterUtil() {
   >          .registerSubtype(ExecuteResult.class, "execute_result")
   >          .registerSubtype(DisplayData.class, "display_data").registerSubtype(Stream.class, "stream")
   >          .registerSubtype(Error.class, "error");
   > -    this.markdownProcessor = new PegdownParser();
   > +    this.markdownProcessor = new FlexmarkParser();
   >
   > Should put in another PR ?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/zeppelin/pull/4223#pullrequestreview-757619597>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AA3R7FWTSQNVU5QRJP773HDUCNP2TANCNFSM5EBWG5DQ>
   > .
   >
   -- 
   이종열, Jongyoul Lee, 李宗烈
   http://madeng.net
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org