[jira] [Commented] (FLINK-5903) taskmanager.numberOfTaskSlots and yarn.containers.vcores did not work well in YARN mode

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894102#comment-15894102 ] 

ASF GitHub Bot commented on FLINK-5903:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3408#discussion_r104125523
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
    @@ -537,7 +543,6 @@ public YarnClusterClient createCluster(
     		Preconditions.checkNotNull(userJarFiles, "User jar files should not be null.");
     
     		AbstractYarnClusterDescriptor yarnClusterDescriptor = createDescriptor(applicationName, cmdLine);
    -		yarnClusterDescriptor.setFlinkConfiguration(config);
    --- End diff --
    
    You should give this configuration to the `createDescriptor`  method where it is used to instantiate the `YarnClusterDescriptor`.


> taskmanager.numberOfTaskSlots and yarn.containers.vcores did not work well in YARN mode
> ---------------------------------------------------------------------------------------
>
>                 Key: FLINK-5903
>                 URL: https://issues.apache.org/jira/browse/FLINK-5903
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>            Reporter: Tao Wang
>            Assignee: Tao Wang
>         Attachments: set taskmanager.numberOfTaskSlots to 6.JPG, set yarn.container.vcores to 5_JM.JPG, set yarn.container.vcores to 5_RM.JPG
>
>
> Now Flink did not respect taskmanager.numberOfTaskSlots and yarn.containers.vcores in flink-conf.yaml, but only -s parameter in CLI.
> Details is that taskmanager.numberOfTaskSlots is not working in anyway andyarn.containers.vcores is only used in requesting container(TM) resources but not aware to TM, which means TM will always think it has default(1) Slots if -s is not configured.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)