You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/02 08:07:34 UTC

[GitHub] [spark] HeartSaVioR commented on a change in pull request #26714: [SPARK-25100][CORE] Fix no registering TaskCommitMessage bug

HeartSaVioR commented on a change in pull request #26714: [SPARK-25100][CORE] Fix no registering TaskCommitMessage bug 
URL: https://github.com/apache/spark/pull/26714#discussion_r352458198
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/FileSuite.scala
 ##########
 @@ -700,4 +701,38 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {
 
     assert(collectRDDAndDeleteFileBeforeCompute(true).isEmpty)
   }
+
+  test("SPARK-25100: Using KryoSerializer and" +
+      "setting registrationRequired true can lead job failed") {
+    val tempDir = Utils.createTempDir()
 
 Review comment:
   There's `tempDir` which FileSuite handles the directory creation per test - let's rely on it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org