[jira] [Commented] (CAMEL-5641) JmsBinding Does Not Handle BigInteger and BigDecimal Properly

["James Carman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461229#comment-13461229 ] 

James Carman commented on CAMEL-5641:
-------------------------------------

I'm going to run the build in my local Jenkins server.  I'll grab the snapshot once it's done.  Thanks!
                
> JmsBinding Does Not Handle BigInteger and BigDecimal Properly
> -------------------------------------------------------------
>
>                 Key: CAMEL-5641
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5641
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-jms
>    Affects Versions: 2.9.3, 2.10.1
>         Environment: java version "1.6.0_35"
> Java(TM) SE Runtime Environment (build 1.6.0_35-b10-428-11M3811)
> Java HotSpot(TM) 64-Bit Server VM (build 20.10-b01-428, mixed mode)
>            Reporter: James Carman
>            Assignee: Christian Müller
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.9.4, 2.11.0, 2.10.2
>
>         Attachments: CAMEL-5641.patch
>
>
> According to the documentation:
> "The values must be primitives or their counter objects (such as
> Integer, Long, Character). The types, String, CharSequence, Date,
> BigDecimal and BigInteger are all converted to their toString()
> representation. All other types are dropped."
> So, it would seem that BigInteger should be toString()ed.  However, in
> the JmsBinding class, we see the following code:
> {code}
> protected Object getValidJMSHeaderValue(String headerName, Object headerValue) {
>         if (headerValue instanceof String) {
>             return headerValue;
>         } else if (headerValue instanceof Number) {
>             return headerValue;
>         } else if (headerValue instanceof Character) {
>             return headerValue;
>         } else if (headerValue instanceof CharSequence) {
>             return headerValue.toString();
>         } else if (headerValue instanceof Boolean) {
>             return headerValue;
>         } else if (headerValue instanceof Date) {
>             return headerValue.toString();
>         }
>         return null;
>     }
> {code}
> Since BigInteger extends Number, it will merely return the instance
> itself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira