[GitHub] nifi pull request #2372: NIFI-4531: LDAP Auth for Docker image

[apiri <gi...@git.apache.org>]

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi/pull/2372

    NIFI-4531: LDAP Auth for Docker image

    NIFI-4531: Providing support for running NiFi Docker image with LDAP authentication provider.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [-] Have you written or updated unit tests to verify your changes?
    - [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [-] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [-] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [-] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/incubator-nifi nifi-4531

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2372.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2372
    
----
commit be89816dd9e63dc0de7e997f7a9f2dc2521d7e2c
Author: Aldrin Piri <al...@...>
Date:   2017-11-29T01:00:32Z

    NIFI-4531:
    Providing support for running NiFi Docker image with LDAP authentication provider.

----


---

[GitHub] nifi pull request #2372: NIFI-4531: LDAP Auth for Docker image

[RobSmithSeattle <gi...@git.apache.org>]

Github user RobSmithSeattle commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2372#discussion_r172335757
  
    --- Diff: nifi-docker/dockerhub/README.md ---
    @@ -74,6 +74,45 @@ Finally, this command makes use of a volume to provide certificates on the host
           -d \
           apache/nifi:latest
     
    +### Standalone Instance, LDAP
    +In this configuration, the user will need to provide certificates and the associated configuration information.  Optionally,
    +if the LDAP provider of interest is operating in LDAPS or START_TLS modes, certificates will additionally be needed.
    +Of particular note, is the `AUTH` environment variable which is set to `ldap`.  Additionally, the user must provide a
    +DN as provided by the configured LDAP server in the `INITIAL_ADMIN_IDENTITY` environment variable. This value will be 
    +used to seed the instance with an initial user with administrative privileges.  Finally, this command makes use of a 
    +volume to provide certificates on the host system to the container instance.
    +
    +#### For a minimal, connection to an LDAP server using SIMPLE authentication:
    +
    +    docker run --name nifi \
    +      -v /User/dreynolds/certs/localhost:/opt/certs \
    +      -p 18443:8443 \
    +      -e AUTH=tls \
    --- End diff --
    
    This looks like an error - the previous paragraph says 
       `AUTH` environment variable which is set to `ldap`.
    
    What is the value supposed to be?


---

[GitHub] nifi pull request #2372: NIFI-4531: LDAP Auth for Docker image

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2372


---