You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2016/11/26 05:13:46 UTC

[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

GitHub user steveblackmon opened a pull request:

    https://github.com/apache/incubator-streams/pull/331

    STREAMS-458: GPlusTypeConverter fix + gplus converter integration testing

    GPlusTypeConverter fails processing recent plus#person w\u2026ithout a gender
    
    Run type converter on live-collected documents during integration test cycle.
    Collect both a person and an organization.
    Check that nodes are present before accessing them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/steveblackmon/incubator-streams STREAMS-458

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #331
    
----
commit f15ca8897806281c7e60f97142e7f151bb0291e4
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date:   2016-11-26T02:18:42Z

    STREAMS-458: GPlusTypeConverter fails processing recent plus#person without a gender
    
    Run type converter on live-collected documents during integration test cycle.
    Collect both a person and an organization.
    Check that nodes are present before accessing them.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/331#discussion_r89666770
  
    --- Diff: streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java ---
    @@ -121,16 +122,10 @@ public void testProcessActivity() throws IOException, ActivitySerializerExceptio
             GooglePlusActivityUtil.updateActivity(gPlusActivity, activity);
     
             assertEquals(retList.size(), 1);
    -        assert (retList.get(0).getDocument() instanceof Activity);
    +        assert(retList.get(0).getDocument() instanceof Activity);
    --- End diff --
    
    change to Assert.assertTrue(retList.get(0) instanceOf Activity);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams issue #331: STREAMS-458: GPlusTypeConverter fix + gplus co...

Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the issue:

    https://github.com/apache/incubator-streams/pull/331
  
    reopen...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/331#discussion_r89666757
  
    --- Diff: streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java ---
    @@ -93,15 +93,17 @@ public void testProcessPerson() throws IOException, ActivitySerializerException
             GooglePlusActivityUtil.updateActivity(person, activity);
     
             assertEquals(retList.size(), 1);
    -        assert (retList.get(0).getDocument() instanceof Activity);
    +        assert(retList.get(0).getDocument() instanceof Activity);
    --- End diff --
    
    change all 'assert' to 'Assert.assertXXX()'. this needs to be done here and many other places in the project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/331#discussion_r89666745
  
    --- Diff: streams-contrib/streams-provider-google/google-gplus/src/test/java/org/apache/streams/gplus/test/processors/GooglePlusTypeConverterIT.java ---
    @@ -27,18 +27,19 @@
     import com.fasterxml.jackson.databind.ObjectMapper;
     import com.fasterxml.jackson.databind.module.SimpleModule;
     import com.google.api.services.plus.model.Person;
    +import com.google.gplus.processor.GooglePlusTypeConverter;
     import com.google.gplus.serializer.util.GPlusActivityDeserializer;
     import com.google.gplus.serializer.util.GPlusPersonDeserializer;
     import com.google.gplus.serializer.util.GooglePlusActivityUtil;
    -
     import org.apache.commons.lang.StringUtils;
    --- End diff --
    
    use lang3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request #331: STREAMS-458: GPlusTypeConverter fix + g...

Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon closed the pull request at:

    https://github.com/apache/incubator-streams/pull/331


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams issue #331: STREAMS-458: GPlusTypeConverter fix + gplus co...

Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the issue:

    https://github.com/apache/incubator-streams/pull/331
  
    rebasing, will reopen



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams issue #331: STREAMS-458: GPlusTypeConverter fix + gplus co...

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-streams/pull/331
  
    lgtm +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams issue #331: STREAMS-458: GPlusTypeConverter fix + gplus co...

Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the issue:

    https://github.com/apache/incubator-streams/pull/331
  
    rebasing, will 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---