You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2011/11/14 03:33:51 UTC
[jira] Created: (MDEP-338) Use of default excludes in unpack should
be configurable
Use of default excludes in unpack should be configurable
--------------------------------------------------------
Key: MDEP-338
URL: https://jira.codehaus.org/browse/MDEP-338
Project: Maven 2.x Dependency Plugin
Issue Type: Bug
Components: unpack, unpack-dependencies
Affects Versions: 2.3
Reporter: Brett Porter
In the unpack method, include/exclude selectors are used, which have "default excludes" configured. This can not be turned off.
I believe this option should be available, and it should default to {{false}}. While this changes behaviour in some instances (though not all, due to a bug - see related issue MDEP-337), I believe it is the expected behaviour. The default excludes are not expected to be present in the archive in the first place.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-338) Use of default excludes in unpack should
be configurable
Posted by "Keith E. Campbell (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith E. Campbell updated MDEP-338:
-----------------------------------
Attachment: useDefaultExcludes.patch
UnpackMojo.patch
AbstractDependencyMojo.patch
Here is a possible patch generated against plugin version 2.3.
> Use of default excludes in unpack should be configurable
> --------------------------------------------------------
>
> Key: MDEP-338
> URL: https://jira.codehaus.org/browse/MDEP-338
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.3
> Reporter: Brett Porter
> Attachments: AbstractDependencyMojo.patch, UnpackMojo.patch, useDefaultExcludes.patch
>
>
> In the unpack method, include/exclude selectors are used, which have "default excludes" configured. This can not be turned off.
> I believe this option should be available, and it should default to {{false}}. While this changes behaviour in some instances (though not all, due to a bug - see related issue MDEP-337), I believe it is the expected behaviour. The default excludes are not expected to be present in the archive in the first place.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-338) Use of default excludes in unpack should
be configurable
Posted by "Keith E. Campbell (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith E. Campbell updated MDEP-338:
-----------------------------------
Attachment: AbstractDependencyMojo.patch
> Use of default excludes in unpack should be configurable
> --------------------------------------------------------
>
> Key: MDEP-338
> URL: https://jira.codehaus.org/browse/MDEP-338
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.3
> Reporter: Brett Porter
> Attachments: AbstractDependencyMojo.patch, AbstractDependencyMojo.patch, UnpackMojo.patch, useDefaultExcludes.patch
>
>
> In the unpack method, include/exclude selectors are used, which have "default excludes" configured. This can not be turned off.
> I believe this option should be available, and it should default to {{false}}. While this changes behaviour in some instances (though not all, due to a bug - see related issue MDEP-337), I believe it is the expected behaviour. The default excludes are not expected to be present in the archive in the first place.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDEP-338) Use of default excludes in unpack
should be configurable
Posted by "Keith E. Campbell (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283373#comment-283373 ]
Keith E. Campbell commented on MDEP-338:
----------------------------------------
Sorry for the bungled file attach. The correct three files are:
AbstractDependencyMojo.patch
UnpackDependenciesMojo.patch
UnpackMojo.patch
The useDefaultExcludes was posted in error.
> Use of default excludes in unpack should be configurable
> --------------------------------------------------------
>
> Key: MDEP-338
> URL: https://jira.codehaus.org/browse/MDEP-338
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.3
> Reporter: Brett Porter
> Attachments: AbstractDependencyMojo.patch, AbstractDependencyMojo.patch, UnpackDependenciesMojo.patch, UnpackMojo.patch, useDefaultExcludes.patch
>
>
> In the unpack method, include/exclude selectors are used, which have "default excludes" configured. This can not be turned off.
> I believe this option should be available, and it should default to {{false}}. While this changes behaviour in some instances (though not all, due to a bug - see related issue MDEP-337), I believe it is the expected behaviour. The default excludes are not expected to be present in the archive in the first place.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-338) Use of default excludes in unpack should
be configurable
Posted by "Keith E. Campbell (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MDEP-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith E. Campbell updated MDEP-338:
-----------------------------------
Attachment: UnpackDependenciesMojo.patch
> Use of default excludes in unpack should be configurable
> --------------------------------------------------------
>
> Key: MDEP-338
> URL: https://jira.codehaus.org/browse/MDEP-338
> Project: Maven 2.x Dependency Plugin
> Issue Type: Bug
> Components: unpack, unpack-dependencies
> Affects Versions: 2.3
> Reporter: Brett Porter
> Attachments: AbstractDependencyMojo.patch, AbstractDependencyMojo.patch, UnpackDependenciesMojo.patch, UnpackMojo.patch, useDefaultExcludes.patch
>
>
> In the unpack method, include/exclude selectors are used, which have "default excludes" configured. This can not be turned off.
> I believe this option should be available, and it should default to {{false}}. While this changes behaviour in some instances (though not all, due to a bug - see related issue MDEP-337), I believe it is the expected behaviour. The default excludes are not expected to be present in the archive in the first place.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira