You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2026/01/05 08:50:58 UTC

[PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

zhangstar333 opened a new pull request, #59564:
URL: https://github.com/apache/doris/pull/59564

   ### What problem does this PR solve?
   Related PR: #53399
   Problem Summary:
   the serializePartitionValue function will return String value.
   But the binary type use String with utf8 will be cause data corrupted, and it is not same with origin data.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [x] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3714178364

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172372 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 4a2629eacfb03f772b5f48f86f979b1c08f7a051, data reload: false
   
   query5	4849	592	424	424
   query6	330	227	201	201
   query7	4225	458	259	259
   query8	331	236	228	228
   query9	8762	2622	2640	2622
   query10	508	367	317	317
   query11	15246	15286	14796	14796
   query12	198	114	113	113
   query13	1256	466	367	367
   query14	6035	2907	2693	2693
   query14_1	2594	2580	2621	2580
   query15	210	194	175	175
   query16	986	458	436	436
   query17	1046	661	547	547
   query18	2449	463	339	339
   query19	232	220	194	194
   query20	121	119	113	113
   query21	215	137	124	124
   query22	3875	3945	4241	3945
   query23	16235	15684	15452	15452
   query23_1	15342	15417	15574	15417
   query24	7428	1563	1180	1180
   query24_1	1168	1166	1192	1166
   query25	563	478	433	433
   query26	1116	272	157	157
   query27	2755	446	293	293
   query28	4540	2135	2142	2135
   query29	817	560	462	462
   query30	314	240	210	210
   query31	804	637	559	559
   query32	80	70	75	70
   query33	545	371	294	294
   query34	877	877	517	517
   query35	755	782	715	715
   query36	879	868	754	754
   query37	135	92	82	82
   query38	2695	2704	2615	2615
   query39	773	766	732	732
   query39_1	717	714	715	714
   query40	219	138	121	121
   query41	73	71	67	67
   query42	105	106	102	102
   query43	474	444	437	437
   query44	1302	724	717	717
   query45	189	185	177	177
   query46	855	962	587	587
   query47	1387	1460	1437	1437
   query48	316	326	244	244
   query49	616	422	334	334
   query50	633	282	219	219
   query51	3783	3780	3744	3744
   query52	104	108	100	100
   query53	284	325	274	274
   query54	299	270	261	261
   query55	76	78	75	75
   query56	300	320	297	297
   query57	1048	1004	922	922
   query58	270	263	301	263
   query59	2154	2018	2015	2015
   query60	319	317	296	296
   query61	160	160	153	153
   query62	405	354	310	310
   query63	294	265	277	265
   query64	4874	1290	975	975
   query65	3777	3668	3699	3668
   query66	1400	410	309	309
   query67	15427	15216	14830	14830
   query68	6552	996	708	708
   query69	496	352	305	305
   query70	1044	920	969	920
   query71	374	301	270	270
   query72	6018	3488	3407	3407
   query73	772	719	301	301
   query74	8862	8745	8568	8568
   query75	2820	2805	2492	2492
   query76	3820	1055	642	642
   query77	566	366	282	282
   query78	9687	9759	9111	9111
   query79	1492	914	584	584
   query80	680	589	493	493
   query81	511	261	231	231
   query82	214	144	110	110
   query83	257	251	239	239
   query84	260	119	106	106
   query85	895	517	453	453
   query86	384	325	324	324
   query87	2901	2853	2761	2761
   query88	3330	2220	2213	2213
   query89	387	344	325	325
   query90	2084	161	153	153
   query91	175	171	144	144
   query92	81	66	64	64
   query93	2355	892	527	527
   query94	572	325	256	256
   query95	582	332	354	332
   query96	581	471	210	210
   query97	2300	2342	2272	2272
   query98	230	202	202	202
   query99	589	607	512	512
   Total cold run time: 254202 ms
   Total hot run time: 172372 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713556548

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173439 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 672bdfd5a23e38fe4b41d03f3474109b9c37d6bf, data reload: false
   
   query5	4474	593	443	443
   query6	334	227	208	208
   query7	3693	470	264	264
   query8	333	248	234	234
   query9	7412	2679	2678	2678
   query10	427	375	333	333
   query11	14888	15223	14824	14824
   query12	169	120	115	115
   query13	513	503	378	378
   query14	3135	3005	2828	2828
   query14_1	2729	2688	2701	2688
   query15	194	195	180	180
   query16	663	482	470	470
   query17	663	702	598	598
   query18	2006	453	356	356
   query19	231	237	205	205
   query20	131	118	116	116
   query21	217	142	131	131
   query22	4018	4293	4041	4041
   query23	15972	15647	15351	15351
   query23_1	15631	15469	15627	15469
   query24	7078	1564	1205	1205
   query24_1	1198	1213	1210	1210
   query25	567	483	430	430
   query26	1248	270	167	167
   query27	2748	463	300	300
   query28	4513	2157	2161	2157
   query29	792	567	479	479
   query30	311	243	214	214
   query31	789	641	565	565
   query32	92	77	71	71
   query33	534	340	294	294
   query34	893	880	530	530
   query35	748	816	714	714
   query36	852	884	858	858
   query37	183	95	74	74
   query38	2734	2797	2658	2658
   query39	778	754	732	732
   query39_1	706	707	721	707
   query40	219	135	114	114
   query41	68	61	61	61
   query42	105	102	104	102
   query43	465	456	427	427
   query44	1346	723	724	723
   query45	184	185	173	173
   query46	878	966	611	611
   query47	1448	1461	1392	1392
   query48	317	333	246	246
   query49	610	404	322	322
   query50	651	279	210	210
   query51	3796	3768	3785	3768
   query52	104	110	97	97
   query53	297	330	280	280
   query54	291	265	240	240
   query55	80	75	76	75
   query56	290	289	289	289
   query57	1076	1001	906	906
   query58	261	248	243	243
   query59	2051	2237	2027	2027
   query60	327	318	335	318
   query61	167	174	173	173
   query62	399	353	313	313
   query63	294	267	273	267
   query64	4950	1305	1018	1018
   query65	3792	3724	3708	3708
   query66	1443	435	293	293
   query67	15185	14829	15871	14829
   query68	7039	1012	709	709
   query69	512	351	307	307
   query70	1006	958	944	944
   query71	359	300	279	279
   query72	6044	3646	3489	3489
   query73	783	729	299	299
   query74	8804	8767	8616	8616
   query75	2832	2842	2453	2453
   query76	3918	1153	660	660
   query77	503	390	269	269
   query78	9895	9870	9110	9110
   query79	1710	924	601	601
   query80	818	557	477	477
   query81	535	261	224	224
   query82	210	152	111	111
   query83	275	251	239	239
   query84	299	121	99	99
   query85	915	522	452	452
   query86	465	335	322	322
   query87	2877	2902	2757	2757
   query88	3182	2219	2221	2219
   query89	376	346	324	324
   query90	2068	158	162	158
   query91	186	165	144	144
   query92	80	67	60	60
   query93	1574	923	531	531
   query94	641	319	282	282
   query95	579	372	303	303
   query96	583	462	204	204
   query97	2316	2366	2289	2289
   query98	231	198	211	198
   query99	588	608	505	505
   Total cold run time: 243663 ms
   Total hot run time: 173439 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3710886564

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.42 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 7223bb90544be70f0861bd250517c9e906dd8f2a, data reload: false
   
   query1	0.05	0.05	0.05
   query2	0.10	0.05	0.05
   query3	0.26	0.09	0.09
   query4	1.62	0.11	0.11
   query5	0.27	0.26	0.26
   query6	1.16	0.67	0.66
   query7	0.03	0.02	0.02
   query8	0.06	0.04	0.04
   query9	0.56	0.51	0.49
   query10	0.55	0.54	0.53
   query11	0.14	0.10	0.09
   query12	0.14	0.11	0.11
   query13	0.60	0.59	0.60
   query14	0.95	0.98	0.96
   query15	0.79	0.77	0.78
   query16	0.42	0.40	0.41
   query17	1.07	1.00	1.08
   query18	0.23	0.21	0.22
   query19	1.86	1.83	1.81
   query20	0.02	0.02	0.01
   query21	15.44	0.25	0.14
   query22	5.19	0.04	0.04
   query23	15.92	0.29	0.10
   query24	1.46	0.83	0.92
   query25	0.12	0.05	0.13
   query26	0.14	0.15	0.14
   query27	0.07	0.05	0.06
   query28	6.28	1.05	0.89
   query29	12.60	3.92	3.13
   query30	0.28	0.14	0.11
   query31	2.83	0.65	0.41
   query32	3.24	0.57	0.45
   query33	2.98	3.00	3.10
   query34	16.59	5.21	4.51
   query35	4.50	4.50	4.47
   query36	0.67	0.50	0.50
   query37	0.11	0.07	0.06
   query38	0.06	0.04	0.03
   query39	0.05	0.03	0.03
   query40	0.16	0.14	0.14
   query41	0.09	0.03	0.03
   query42	0.05	0.04	0.03
   query43	0.04	0.04	0.03
   Total cold run time: 99.75 s
   Total hot run time: 27.42 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on code in PR #59564:
URL: https://github.com/apache/doris/pull/59564#discussion_r2672644888


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonUtil.java:
##########
@@ -456,12 +455,8 @@ private static String serializePartitionValue(org.apache.paimon.types.DataType t
                     return null;
                 }
                 return value.toString();
-            case BINARY:

Review Comment:
   // binary type as partition key will cause issues in paimon, so skipping these tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3709813998

   # FE UT Coverage Report
   Increment line coverage `  100% (0/0)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59564_b0d0b00e0f70f8a3cea3f72fa5555f4b8630b467/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59564_b0d0b00e0f70f8a3cea3f72fa5555f4b8630b467/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3709475317

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3709856376

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172938 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit b0d0b00e0f70f8a3cea3f72fa5555f4b8630b467, data reload: false
   
   query5	4781	576	438	438
   query6	338	225	209	209
   query7	4229	445	263	263
   query8	319	233	226	226
   query9	8776	2634	2633	2633
   query10	526	372	311	311
   query11	15356	15066	14840	14840
   query12	174	117	110	110
   query13	1251	480	386	386
   query14	6271	2942	2698	2698
   query14_1	2617	2604	2616	2604
   query15	208	189	177	177
   query16	1013	464	446	446
   query17	1074	683	576	576
   query18	2522	453	345	345
   query19	225	225	196	196
   query20	133	117	115	115
   query21	217	141	123	123
   query22	4106	4228	4271	4228
   query23	16290	15864	15602	15602
   query23_1	15650	15575	15527	15527
   query24	7406	1563	1154	1154
   query24_1	1180	1158	1178	1158
   query25	550	468	419	419
   query26	1260	271	166	166
   query27	2750	470	291	291
   query28	4516	2147	2133	2133
   query29	813	554	464	464
   query30	317	240	210	210
   query31	801	628	542	542
   query32	83	73	70	70
   query33	532	351	303	303
   query34	898	865	521	521
   query35	747	767	739	739
   query36	861	859	810	810
   query37	120	86	73	73
   query38	2751	2713	2603	2603
   query39	776	773	739	739
   query39_1	713	703	708	703
   query40	214	131	113	113
   query41	65	64	60	60
   query42	102	99	100	99
   query43	431	448	447	447
   query44	1308	726	723	723
   query45	186	187	174	174
   query46	854	958	582	582
   query47	1379	1438	1362	1362
   query48	304	320	252	252
   query49	605	412	308	308
   query50	646	266	198	198
   query51	3773	3709	3755	3709
   query52	106	108	94	94
   query53	299	324	270	270
   query54	271	256	236	236
   query55	80	76	71	71
   query56	291	289	277	277
   query57	1032	1046	960	960
   query58	261	247	291	247
   query59	2104	2130	2166	2130
   query60	307	310	289	289
   query61	159	153	153	153
   query62	397	348	332	332
   query63	298	261	271	261
   query64	4934	1271	1000	1000
   query65	3820	3689	3682	3682
   query66	1415	412	301	301
   query67	15033	15765	14925	14925
   query68	8268	994	714	714
   query69	493	339	318	318
   query70	1069	959	929	929
   query71	356	290	274	274
   query72	5991	3368	3411	3368
   query73	776	718	298	298
   query74	8916	8808	8567	8567
   query75	2858	2791	2435	2435
   query76	3988	1062	633	633
   query77	604	346	270	270
   query78	9695	9986	9189	9189
   query79	1267	889	584	584
   query80	619	579	461	461
   query81	518	261	224	224
   query82	205	150	109	109
   query83	259	261	242	242
   query84	260	119	100	100
   query85	884	507	446	446
   query86	389	322	307	307
   query87	2807	2797	2761	2761
   query88	3244	2241	2213	2213
   query89	393	341	324	324
   query90	2187	153	145	145
   query91	166	160	138	138
   query92	82	83	62	62
   query93	1646	888	535	535
   query94	564	318	285	285
   query95	550	368	297	297
   query96	578	461	212	212
   query97	2321	2411	2261	2261
   query98	232	205	191	191
   query99	593	588	536	536
   Total cold run time: 255613 ms
   Total hot run time: 172938 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3709817345

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31832 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit b0d0b00e0f70f8a3cea3f72fa5555f4b8630b467, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17641	4317	4067	4067
   q2	2040	355	248	248
   q3	10155	1293	729	729
   q4	10197	791	315	315
   q5	7470	2087	1842	1842
   q6	191	172	137	137
   q7	947	803	653	653
   q8	9277	1390	1129	1129
   q9	5000	4483	4567	4483
   q10	6790	1831	1404	1404
   q11	512	296	282	282
   q12	723	736	607	607
   q13	17777	3834	3083	3083
   q14	302	301	276	276
   q15	592	516	506	506
   q16	668	672	651	651
   q17	685	801	552	552
   q18	6681	6229	6880	6229
   q19	1182	1002	646	646
   q20	472	397	256	256
   q21	3206	2645	2720	2645
   q22	1133	1102	1092	1092
   Total cold run time: 103641 ms
   Total hot run time: 31832 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4237	4391	4296	4296
   q2	345	398	332	332
   q3	2377	2769	2541	2541
   q4	1406	1843	1463	1463
   q5	4604	4518	4274	4274
   q6	210	165	124	124
   q7	2005	1947	1802	1802
   q8	2499	2398	2442	2398
   q9	7125	7134	7191	7134
   q10	2451	2695	2342	2342
   q11	573	490	451	451
   q12	709	846	598	598
   q13	3499	3817	3080	3080
   q14	268	278	279	278
   q15	521	487	482	482
   q16	598	651	598	598
   q17	1113	1226	1298	1226
   q18	7476	7268	7465	7268
   q19	814	783	820	783
   q20	1903	1937	1811	1811
   q21	4583	4210	4117	4117
   q22	1137	1050	995	995
   Total cold run time: 50453 ms
   Total hot run time: 48393 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3715007938

   # FE Regression Coverage Report
   Increment line coverage `  14.29% (2/14)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59564_4a2629eacfb03f772b5f48f86f979b1c08f7a051_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59564_4a2629eacfb03f772b5f48f86f979b1c08f7a051_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on code in PR #59564:
URL: https://github.com/apache/doris/pull/59564#discussion_r2672557878


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonUtil.java:
##########
@@ -456,12 +455,8 @@ private static String serializePartitionValue(org.apache.paimon.types.DataType t
                     return null;
                 }
                 return value.toString();
-            case BINARY:

Review Comment:
   A corresponding case needs to be added for paimon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3715025338

   # FE Regression Coverage Report
   Increment line coverage `  14.29% (2/14)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59564_4a2629eacfb03f772b5f48f86f979b1c08f7a051_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59564_4a2629eacfb03f772b5f48f86f979b1c08f7a051_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3711018838

   # BE UT Coverage Report
   Increment line coverage `100.00% (6/6)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/7223bb90544be70f0861bd250517c9e906dd8f2a_7223bb90544be70f0861bd250517c9e906dd8f2a/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/7223bb90544be70f0861bd250517c9e906dd8f2a_7223bb90544be70f0861bd250517c9e906dd8f2a/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 53.21% (18961/35637) |
   | Line Coverage     | 39.20% (175925/448804) |
   | Region Coverage   | 33.71% (136055/403635) |
   | Branch Coverage   | 34.68% (58714/169314) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 merged PR #59564:
URL: https://github.com/apache/doris/pull/59564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3709872278

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.09 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit b0d0b00e0f70f8a3cea3f72fa5555f4b8630b467, data reload: false
   
   query1	0.05	0.04	0.04
   query2	0.10	0.05	0.04
   query3	0.26	0.08	0.08
   query4	1.61	0.12	0.11
   query5	0.28	0.25	0.26
   query6	1.15	0.65	0.64
   query7	0.03	0.03	0.02
   query8	0.05	0.04	0.04
   query9	0.56	0.52	0.50
   query10	0.55	0.54	0.54
   query11	0.14	0.09	0.09
   query12	0.16	0.10	0.10
   query13	0.61	0.58	0.59
   query14	0.96	0.94	0.94
   query15	0.78	0.77	0.77
   query16	0.40	0.42	0.38
   query17	1.00	0.97	1.00
   query18	0.24	0.21	0.21
   query19	1.83	1.78	1.91
   query20	0.01	0.01	0.02
   query21	15.48	0.26	0.14
   query22	5.06	0.05	0.04
   query23	15.75	0.29	0.10
   query24	1.99	0.61	0.60
   query25	0.08	0.09	0.08
   query26	0.14	0.14	0.13
   query27	0.08	0.06	0.06
   query28	4.98	1.05	0.88
   query29	12.60	3.94	3.19
   query30	0.28	0.14	0.13
   query31	2.83	0.67	0.39
   query32	3.24	0.57	0.47
   query33	3.02	3.04	3.05
   query34	16.69	5.12	4.48
   query35	4.53	4.47	4.44
   query36	0.66	0.53	0.48
   query37	0.11	0.06	0.06
   query38	0.08	0.04	0.04
   query39	0.04	0.03	0.03
   query40	0.16	0.15	0.13
   query41	0.08	0.03	0.03
   query42	0.04	0.04	0.03
   query43	0.04	0.04	0.03
   Total cold run time: 98.73 s
   Total hot run time: 27.09 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713359195

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713463121

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713039000

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (6/6)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59564_7223bb90544be70f0861bd250517c9e906dd8f2a_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59564_7223bb90544be70f0861bd250517c9e906dd8f2a_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 60.81% (21185/34838) |
   | Line Coverage     | 47.08% (210740/447586) |
   | Region Coverage   | 42.34% (172662/407755) |
   | Branch Coverage   | 42.61% (72382/169863) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3714200634

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 26.94 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 4a2629eacfb03f772b5f48f86f979b1c08f7a051, data reload: false
   
   query1	0.06	0.04	0.04
   query2	0.09	0.05	0.05
   query3	0.26	0.09	0.09
   query4	1.60	0.11	0.12
   query5	0.26	0.26	0.25
   query6	1.16	0.66	0.65
   query7	0.03	0.02	0.02
   query8	0.05	0.04	0.04
   query9	0.55	0.51	0.50
   query10	0.55	0.55	0.54
   query11	0.14	0.10	0.10
   query12	0.14	0.10	0.11
   query13	0.61	0.61	0.60
   query14	0.94	0.97	0.96
   query15	0.79	0.80	0.77
   query16	0.39	0.40	0.41
   query17	1.06	1.08	1.08
   query18	0.22	0.21	0.21
   query19	1.88	1.85	1.86
   query20	0.02	0.02	0.01
   query21	15.44	0.29	0.13
   query22	5.56	0.05	0.05
   query23	16.26	0.28	0.10
   query24	1.40	0.26	0.27
   query25	0.11	0.08	0.11
   query26	0.14	0.14	0.14
   query27	0.08	0.06	0.05
   query28	3.42	1.06	0.89
   query29	12.59	3.93	3.18
   query30	0.27	0.14	0.11
   query31	2.82	0.66	0.40
   query32	3.25	0.55	0.46
   query33	2.96	3.06	3.04
   query34	16.64	5.17	4.44
   query35	4.47	4.40	4.44
   query36	0.66	0.50	0.50
   query37	0.10	0.07	0.06
   query38	0.07	0.04	0.04
   query39	0.05	0.03	0.03
   query40	0.17	0.15	0.13
   query41	0.09	0.04	0.02
   query42	0.05	0.03	0.03
   query43	0.04	0.04	0.03
   Total cold run time: 97.44 s
   Total hot run time: 26.94 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3714536359

   # FE Regression Coverage Report
   Increment line coverage `  14.29% (2/14)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59564_4a2629eacfb03f772b5f48f86f979b1c08f7a051_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59564_4a2629eacfb03f772b5f48f86f979b1c08f7a051_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3714130794

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31814 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 4a2629eacfb03f772b5f48f86f979b1c08f7a051, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17657	4194	4983	4194
   q2	2034	359	241	241
   q3	10150	1284	698	698
   q4	10224	897	332	332
   q5	7509	2145	1900	1900
   q6	197	178	140	140
   q7	940	808	640	640
   q8	9281	1417	1173	1173
   q9	4904	4604	4610	4604
   q10	6795	1779	1417	1417
   q11	508	305	307	305
   q12	713	715	595	595
   q13	17792	3848	3153	3153
   q14	292	291	271	271
   q15	595	513	504	504
   q16	692	696	640	640
   q17	688	817	567	567
   q18	6507	6483	6376	6376
   q19	1098	968	574	574
   q20	406	370	250	250
   q21	3087	2485	2293	2293
   q22	1047	1008	947	947
   Total cold run time: 103116 ms
   Total hot run time: 31814 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4065	4044	4015	4015
   q2	323	429	308	308
   q3	2051	2606	2219	2219
   q4	1318	1746	1325	1325
   q5	4125	4021	4174	4021
   q6	201	165	129	129
   q7	1885	1784	2007	1784
   q8	2618	2472	2400	2400
   q9	7246	7020	7086	7020
   q10	2435	2786	2321	2321
   q11	566	478	453	453
   q12	747	813	624	624
   q13	3616	4129	3399	3399
   q14	307	383	316	316
   q15	555	511	497	497
   q16	671	693	632	632
   q17	1182	1447	1461	1447
   q18	8134	7798	7678	7678
   q19	873	878	919	878
   q20	2112	2099	1981	1981
   q21	4940	4642	4349	4349
   q22	1061	1045	971	971
   Total cold run time: 51031 ms
   Total hot run time: 48767 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3724084507

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3710673455

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3710824391

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31389 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 7223bb90544be70f0861bd250517c9e906dd8f2a, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17615	4210	4091	4091
   q2	2029	355	243	243
   q3	10163	1245	740	740
   q4	10214	900	323	323
   q5	7546	2094	1813	1813
   q6	197	178	144	144
   q7	924	797	649	649
   q8	9270	1386	1162	1162
   q9	4851	4634	4564	4564
   q10	6799	1786	1365	1365
   q11	531	306	295	295
   q12	664	726	568	568
   q13	17797	3814	3124	3124
   q14	283	283	265	265
   q15	587	504	502	502
   q16	684	672	632	632
   q17	673	803	526	526
   q18	6597	6412	6260	6260
   q19	1091	978	586	586
   q20	387	360	250	250
   q21	3002	2416	2321	2321
   q22	1012	1016	966	966
   Total cold run time: 102916 ms
   Total hot run time: 31389 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4106	4103	4071	4071
   q2	325	384	318	318
   q3	2045	2580	2165	2165
   q4	1298	1732	1348	1348
   q5	4072	4032	4018	4018
   q6	212	170	133	133
   q7	1859	1743	1658	1658
   q8	2799	2448	2406	2406
   q9	7181	7158	7014	7014
   q10	2513	2723	2304	2304
   q11	549	489	444	444
   q12	727	770	629	629
   q13	3569	4013	3435	3435
   q14	296	305	410	305
   q15	564	496	529	496
   q16	682	673	646	646
   q17	1160	1327	1429	1327
   q18	8102	8214	7944	7944
   q19	928	921	915	915
   q20	2009	2189	2000	2000
   q21	4780	4577	4118	4118
   q22	1047	1030	1020	1020
   Total cold run time: 50823 ms
   Total hot run time: 48714 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713453792

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31904 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 40f886fc44af28143dfeb2340d6974303b07a685, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17624	4372	4063	4063
   q2	2009	371	262	262
   q3	10155	1276	726	726
   q4	10207	885	322	322
   q5	7550	2072	1857	1857
   q6	184	168	137	137
   q7	940	809	650	650
   q8	9278	1424	1140	1140
   q9	4797	4607	4534	4534
   q10	6752	1772	1426	1426
   q11	539	287	279	279
   q12	690	752	579	579
   q13	17765	3875	3057	3057
   q14	288	300	274	274
   q15	577	514	519	514
   q16	685	670	640	640
   q17	684	791	573	573
   q18	6661	6347	6870	6347
   q19	1268	1029	644	644
   q20	437	398	280	280
   q21	3150	2581	2558	2558
   q22	1148	1110	1042	1042
   Total cold run time: 103388 ms
   Total hot run time: 31904 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4367	4282	4378	4282
   q2	326	414	339	339
   q3	2273	2816	2458	2458
   q4	1404	1815	1608	1608
   q5	4329	4161	4324	4161
   q6	222	169	129	129
   q7	1930	1915	1906	1906
   q8	2548	2349	2440	2349
   q9	6888	7286	7181	7181
   q10	2477	2756	2307	2307
   q11	579	486	458	458
   q12	742	732	658	658
   q13	3704	4004	3338	3338
   q14	307	298	273	273
   q15	539	511	500	500
   q16	654	698	643	643
   q17	1124	1288	1320	1288
   q18	7439	7400	7371	7371
   q19	824	804	829	804
   q20	1877	1983	1812	1812
   q21	4460	4342	4129	4129
   q22	1069	1010	998	998
   Total cold run time: 50082 ms
   Total hot run time: 48992 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713755607

   # FE UT Coverage Report
   Increment line coverage `  50.00% (7/14)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59564_672bdfd5a23e38fe4b41d03f3474109b9c37d6bf/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59564_672bdfd5a23e38fe4b41d03f3474109b9c37d6bf/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713937657

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3710865234

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173256 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 7223bb90544be70f0861bd250517c9e906dd8f2a, data reload: false
   
   query5	4398	587	454	454
   query6	340	237	215	215
   query7	4216	454	270	270
   query8	347	253	252	252
   query9	8769	2637	2652	2637
   query10	542	367	337	337
   query11	15221	14974	14969	14969
   query12	173	114	115	114
   query13	1260	491	388	388
   query14	6194	3018	2796	2796
   query14_1	2691	2645	2654	2645
   query15	200	199	175	175
   query16	982	453	472	453
   query17	1121	676	585	585
   query18	2446	442	343	343
   query19	227	222	194	194
   query20	130	117	114	114
   query21	212	143	124	124
   query22	3768	3845	3935	3845
   query23	16038	15505	15344	15344
   query23_1	15400	15386	15369	15369
   query24	7364	1574	1168	1168
   query24_1	1194	1198	1204	1198
   query25	565	484	420	420
   query26	1237	269	164	164
   query27	2769	474	288	288
   query28	4521	2146	2141	2141
   query29	815	554	464	464
   query30	309	242	210	210
   query31	805	638	560	560
   query32	78	77	68	68
   query33	565	346	293	293
   query34	879	888	526	526
   query35	750	834	695	695
   query36	894	890	781	781
   query37	123	94	80	80
   query38	2747	2739	2663	2663
   query39	781	736	718	718
   query39_1	707	708	709	708
   query40	217	134	112	112
   query41	65	61	64	61
   query42	103	100	103	100
   query43	460	478	421	421
   query44	1364	725	720	720
   query45	183	180	176	176
   query46	848	980	591	591
   query47	1408	1467	1317	1317
   query48	304	327	257	257
   query49	603	411	320	320
   query50	638	274	203	203
   query51	3749	3814	3705	3705
   query52	110	106	98	98
   query53	295	329	271	271
   query54	280	252	249	249
   query55	75	74	70	70
   query56	283	292	284	284
   query57	1002	928	895	895
   query58	303	261	250	250
   query59	2085	2191	2171	2171
   query60	314	321	290	290
   query61	163	158	160	158
   query62	386	348	340	340
   query63	297	267	273	267
   query64	4961	1309	1018	1018
   query65	3844	3666	3713	3666
   query66	1438	415	307	307
   query67	14772	15688	15307	15307
   query68	8027	984	702	702
   query69	499	339	309	309
   query70	999	927	917	917
   query71	361	297	278	278
   query72	6024	3419	3416	3416
   query73	772	735	305	305
   query74	8793	8729	8544	8544
   query75	2842	2835	2494	2494
   query76	3909	1057	656	656
   query77	515	372	270	270
   query78	9585	9815	9148	9148
   query79	1376	917	596	596
   query80	608	579	479	479
   query81	507	263	223	223
   query82	214	141	109	109
   query83	270	264	238	238
   query84	258	113	105	105
   query85	879	504	459	459
   query86	387	331	288	288
   query87	2922	2841	2730	2730
   query88	3735	2237	2223	2223
   query89	389	355	312	312
   query90	2188	155	152	152
   query91	180	165	148	148
   query92	81	68	65	65
   query93	1677	909	531	531
   query94	575	321	285	285
   query95	575	327	355	327
   query96	577	475	202	202
   query97	2306	2386	2291	2291
   query98	213	194	195	194
   query99	567	575	543	543
   Total cold run time: 254194 ms
   Total hot run time: 173256 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3709474459

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713529530

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31765 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 672bdfd5a23e38fe4b41d03f3474109b9c37d6bf, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17623	4257	4074	4074
   q2	2028	356	240	240
   q3	10164	1315	733	733
   q4	10214	839	322	322
   q5	7879	2140	1919	1919
   q6	219	179	145	145
   q7	957	786	653	653
   q8	9279	1446	1177	1177
   q9	5281	4731	4674	4674
   q10	6841	1799	1396	1396
   q11	521	300	304	300
   q12	781	751	605	605
   q13	17784	3900	3100	3100
   q14	290	290	275	275
   q15	594	514	506	506
   q16	696	691	621	621
   q17	675	832	520	520
   q18	6649	6309	6255	6255
   q19	1088	1002	628	628
   q20	419	379	258	258
   q21	3128	2496	2380	2380
   q22	1067	984	985	984
   Total cold run time: 104177 ms
   Total hot run time: 31765 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4133	4164	4079	4079
   q2	351	402	317	317
   q3	2109	2660	2221	2221
   q4	1342	1767	1313	1313
   q5	4147	3994	4050	3994
   q6	219	167	132	132
   q7	1843	1834	1676	1676
   q8	2485	2348	2373	2348
   q9	6636	6702	6680	6680
   q10	2299	2475	2115	2115
   q11	582	459	442	442
   q12	666	707	559	559
   q13	3424	3809	3173	3173
   q14	278	287	266	266
   q15	543	498	505	498
   q16	624	680	631	631
   q17	1116	1307	1394	1307
   q18	7545	7266	7172	7172
   q19	869	843	857	843
   q20	1945	1968	1821	1821
   q21	4606	4250	4209	4209
   q22	1080	1049	1011	1011
   Total cold run time: 48842 ms
   Total hot run time: 46807 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3713569550

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 26.79 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 672bdfd5a23e38fe4b41d03f3474109b9c37d6bf, data reload: false
   
   query1	0.06	0.05	0.05
   query2	0.10	0.04	0.04
   query3	0.26	0.09	0.09
   query4	1.61	0.11	0.11
   query5	0.27	0.26	0.26
   query6	1.15	0.65	0.66
   query7	0.03	0.02	0.02
   query8	0.05	0.04	0.04
   query9	0.56	0.50	0.50
   query10	0.54	0.54	0.56
   query11	0.15	0.10	0.10
   query12	0.14	0.10	0.11
   query13	0.60	0.58	0.59
   query14	0.96	0.96	0.95
   query15	0.79	0.76	0.80
   query16	0.41	0.41	0.42
   query17	0.99	1.05	1.06
   query18	0.23	0.22	0.21
   query19	1.93	1.84	1.93
   query20	0.01	0.01	0.02
   query21	15.47	0.25	0.13
   query22	5.23	0.05	0.05
   query23	15.88	0.29	0.10
   query24	0.94	0.30	0.19
   query25	0.09	0.09	0.08
   query26	0.14	0.13	0.14
   query27	0.08	0.06	0.06
   query28	3.45	1.05	0.89
   query29	12.62	3.91	3.15
   query30	0.27	0.14	0.12
   query31	2.82	0.64	0.39
   query32	3.24	0.57	0.46
   query33	2.98	3.03	3.07
   query34	16.79	5.12	4.43
   query35	4.52	4.49	4.44
   query36	0.67	0.50	0.48
   query37	0.12	0.06	0.07
   query38	0.08	0.05	0.04
   query39	0.04	0.04	0.03
   query40	0.17	0.14	0.13
   query41	0.09	0.04	0.03
   query42	0.05	0.03	0.03
   query43	0.04	0.03	0.04
   Total cold run time: 96.62 s
   Total hot run time: 26.79 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Bug](catalog) fix runtime filter partition pruning error with binary type [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59564:
URL: https://github.com/apache/doris/pull/59564#issuecomment-3724084345

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org