You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bigtop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/25 13:23:00 UTC

[jira] [Commented] (BIGTOP-3014) juju: use charm-env for shebangs

    [ https://issues.apache.org/jira/browse/BIGTOP-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413029#comment-16413029 ] 

ASF GitHub Bot commented on BIGTOP-3014:
----------------------------------------

GitHub user kwmonroe opened a pull request:

    https://github.com/apache/bigtop/pull/349

    BIGTOP-3014: juju: use charm-env for shebangs

    See [BIGTOP-3014](https://issues.apache.org/jira/browse/BIGTOP-3014) for the meats.
    
    Lots of files changed here, but it's just the shebangs and a few simplifications (no longer need to `sys.path.append('lib')`).  Tested well on Mar 13:
    
    http://bigtop.charm.qa/

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/juju-solutions/bigtop bug/BIGTOP-3014-new-shebang

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #349
    
----
commit 8aee721ea5dbe859a7e9b20ef3fd0b2e973d32ad
Author: Kevin W Monroe <ke...@...>
Date:   2018-03-10T00:26:52Z

    use charm-env shebang for actions to ensure we pick up the right venv

commit 829a37c4b569eff2db7dc2e230ca0985f0af1f81
Author: Kevin W Monroe <ke...@...>
Date:   2018-03-12T17:22:13Z

    be explicit with python3

----


> juju: use charm-env for shebangs
> --------------------------------
>
>                 Key: BIGTOP-3014
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-3014
>             Project: Bigtop
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 1.2.1
>            Reporter: Kevin W Monroe
>            Assignee: Kevin W Monroe
>            Priority: Major
>
> A recent change to layer-basic (all bigtop charms include this) enforced python deps in virtual env:
> [https://github.com/juju-solutions/layer-basic/pull/105]
> This requires a change to charm actions to ensure they activate the venv. It's gonna be a big LOC change to swap the shebangs, but nothing functional.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)