[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

[GitBox <gi...@apache.org>]

nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r317777691
 
 

 ##########
 File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authorization/LDAPRoleProvider.java
 ##########
 @@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.security.basic.authorization;
+
+import com.fasterxml.jackson.annotation.JacksonInject;
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.druid.java.util.common.IAE;
+import org.apache.druid.java.util.common.logger.Logger;
+import org.apache.druid.security.basic.BasicAuthUtils;
+import org.apache.druid.security.basic.authorization.db.cache.BasicAuthorizerCacheManager;
+import org.apache.druid.security.basic.authorization.entity.BasicAuthorizerGroupMapping;
+import org.apache.druid.security.basic.authorization.entity.BasicAuthorizerRole;
+import org.apache.druid.security.basic.authorization.entity.BasicAuthorizerUser;
+import org.apache.druid.server.security.AuthenticationResult;
+
+import javax.naming.InvalidNameException;
+import javax.naming.ldap.LdapName;
+import java.util.HashSet;
+import java.util.Locale;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+
+@JsonTypeName("ldap")
+public class LDAPRoleProvider implements RoleProvider
+{
+  private static final Logger LOG = new Logger(LDAPRoleProvider.class);
+
+  private final BasicAuthorizerCacheManager cacheManager;
+
+  @JsonCreator
+  public LDAPRoleProvider(
+      @JacksonInject BasicAuthorizerCacheManager cacheManager
+  )
+  {
+    this.cacheManager = cacheManager;
+  }
+
+  @Override
+  public Set<String> getRoles(String authorizerPrefix, AuthenticationResult authenticationResult)
+  {
+    Set<String> roleNames = new HashSet<>();
+    Map<String, BasicAuthorizerGroupMapping> groupMappingMap = cacheManager.getGroupMappingMap(authorizerPrefix);
+    if (groupMappingMap == null) {
+      throw new IAE("Could not load groupMappingMap for authorizer [%s]", authorizerPrefix);
+    }
+    Map<String, BasicAuthorizerUser> userMap = cacheManager.getUserMap(authorizerPrefix);
+    if (userMap == null) {
+      throw new IAE("Could not load userMap for authorizer [%s]", authorizerPrefix);
+    }
+
+    // Get the groups assigned to the LDAP user
+    Set<LdapName> groupNamesFromLdap = Optional.ofNullable(authenticationResult.getContext())
+                                               .map(contextMap -> contextMap.get(BasicAuthUtils.GROUPS_CONTEXT_KEY))
+                                               .map(p -> {
+                                                 if (p instanceof Set) {
+                                                   return (Set<LdapName>) p;
+                                                 } else {
+                                                   return null;
+                                                 }
+                                               })
+                                               .orElse(new HashSet<>());
+    if (groupNamesFromLdap.isEmpty()) {
+      LOG.debug("User %s is not mapped to any groups", authenticationResult.getIdentity());
+    } else {
+      // Get the roles mapped to LDAP groups from the metastore.
+      // This allows us to authorize groups LDAP user belongs
+      roleNames.addAll(getRoles(groupMappingMap, groupNamesFromLdap));
+    }
+
+    // Get the roles assigned to LDAP user from the metastore.
+    // This allow us to authorize LDAP users regardless of whether they belong to any groups or not in LDAP.  
+    BasicAuthorizerUser user = userMap.get(authenticationResult.getIdentity());
+    if (user != null) {
+      roleNames.addAll(user.getRoles());
+    }
+
+    return roleNames;
+  }
+
+  @Override
+  public Map<String, BasicAuthorizerRole> getRoleMap(String authorizerPrefix)
+  {
+    return cacheManager.getRoleMap(authorizerPrefix);
+  }
+
+  @VisibleForTesting
+  public Set<String> getRoles(Map<String, BasicAuthorizerGroupMapping> groupMappingMap, Set<LdapName> groupNamesFromLdap)
+  {
+    Set<String> roles = new HashSet<>();
+
+    if (groupMappingMap.size() == 0) {
+      return roles;
+    }
+
+    for (LdapName groupName : groupNamesFromLdap) {
+      for (Map.Entry<String, BasicAuthorizerGroupMapping> groupMappingEntry : groupMappingMap.entrySet()) {
+        BasicAuthorizerGroupMapping groupMapping = groupMappingEntry.getValue();
+        String mask = groupMapping.getGroupPattern();
 
 Review comment:
   nit: can you add a comment explaining the logic of masking a bit. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org