You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "e-mhui (via GitHub)" <gi...@apache.org> on 2023/04/06 14:08:40 UTC
[GitHub] [inlong] e-mhui opened a new pull request, #7794: [INLONG-7790][Sort] Capture newly added tables when setting "scan.newly-added-table.enabled=true" and "scan.startup.mode=latest-offset"
e-mhui opened a new pull request, #7794:
URL: https://github.com/apache/inlong/pull/7794
### Prepare a Pull Request
[INLONG-7790][Sort] Capture newly added tables when setting "scan.newly-added-table.enabled=true" and "scan.startup.mode=latest-offset"
- Fixes #7790
### Motivation
Capture newly added tables when setting "scan.newly-added-table.enabled=true" and "scan.startup.mode=latest-offset"
### Modifications
When executing the `discoverTableSchemasForBinlogSplit()` method, determine whether to query the schema of newly added tables based on `sourceConfig.isScanNewlyAddedTableEnabled()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #7794: [INLONG-7790][Sort] Capture newly added tables when setting "scan.newly-added-table.enabled=true" and "scan.startup.mode=latest-offset"
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap merged PR #7794:
URL: https://github.com/apache/inlong/pull/7794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] supermefz commented on a diff in pull request #7794: [INLONG-7790][Sort] Capture newly added tables when setting "scan.newly-added-table.enabled=true" and "scan.startup.mode=latest-offset"
Posted by "supermefz (via GitHub)" <gi...@apache.org>.
supermefz commented on code in PR #7794:
URL: https://github.com/apache/inlong/pull/7794#discussion_r1160488264
##########
inlong-sort/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/source/reader/MySqlSourceReader.java:
##########
@@ -235,12 +235,22 @@ public void addSplits(List<MySqlSplit> splits) {
private MySqlBinlogSplit discoverTableSchemasForBinlogSplit(MySqlBinlogSplit split) {
final String splitId = split.splitId();
- if (split.getTableSchemas().isEmpty()) {
+ if (split.getTableSchemas().isEmpty() || sourceConfig.isScanNewlyAddedTableEnabled()) {
Review Comment:
1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org