[GitHub] [flink] ericxiao251 commented on pull request #21077: [FLINK-29498] Add Scala Async Retry Strategies and ResultPredicates Helper Classes

[GitBox <gi...@apache.org>]

ericxiao251 commented on PR #21077:
URL: https://github.com/apache/flink/pull/21077#issuecomment-1298937784

   > 2. For AsyncRetryPredicate, we might have a uniform wrapper for Java version of AsyncRetryPredicate. Then we do not need to have Scala version of FixedDelayRetryStrategy and ExponentialBackoffDelayRetryStrategy. Instead we could make FixedDelayRetryStrategyBuilder and ExponentialBackoffDelayRetryStrategyBuilder returns the wrapped strategy directly like
   
   I assume you're talking about `AsyncRetryStrategies` and the reference to `AsyncRetryPredicate` is just a typo? I don't think I fully understand what you're proposing. These are the steps I understand:
   1. Remove the Scala classes `FixedDelayRetryStrategy` and ` ExponentialBackoffDelayRetryStrategy` and only keep the Scala builder classes `FixedDelayRetryStrategyBuilder` and `ExponentialBackoffDelayRetryStrategyBuilder`.
   2. Make the Scala builder classes wrap the Java builder class that returns a Scala `AsyncRetryStrategy`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org