You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2023/09/20 16:55:01 UTC
[GitHub] [incubator-pekko] Roiocam commented on a diff in pull request #664: fix: keep typed ask deadletter same as classic
Roiocam commented on code in PR #664:
URL: https://github.com/apache/incubator-pekko/pull/664#discussion_r1331933499
##########
actor/src/main/scala/org/apache/pekko/pattern/AskSupport.scala:
##########
@@ -617,7 +617,7 @@ private[pekko] final class PromiseActorRef(
override def !(message: Any)(implicit sender: ActorRef = Actor.noSender): Unit = state match {
case Stopped | _: StoppedWithPath =>
- provider.deadLetters ! message
+ provider.deadLetters ! DeadLetter(message, if (sender eq Actor.noSender) provider.deadLetters else sender, this)
Review Comment:
In fact, the sender will always be empty because in typed, the passing of the sender is changed from explicitly on method calling to optional choice as a field in the message, unless we can extract the value with the same field name (such as sender, replyTo) from the user's message and use it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org