[jira] [Commented] (AVRO-1924) Variable named 'date' in IDL

["Martin Jubelgas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727042#comment-16727042 ] 

Martin Jubelgas commented on AVRO-1924:
---------------------------------------

To avoid problems and collisions with reserved words, names can be escaped like
{code:java}
@namespace("org.apache.parquet.avro")
protocol Cars {
    record Service {
        long `date`;
    }
}
{code}
If names are automatically converted and a collision cannot be ruled out, they should be escaped by default, so no problems should arise.

I think this ticket should hence be closed.

> Variable named 'date' in IDL
> ----------------------------
>
>                 Key: AVRO-1924
>                 URL: https://issues.apache.org/jira/browse/AVRO-1924
>             Project: Apache Avro
>          Issue Type: Bug
>    Affects Versions: 1.8.1
>            Reporter: Niels Basjes
>            Assignee: Ryan Blue
>            Priority: Critical
>
> I was compiling Apache Parquet and found that the switch from Avro 1.8.0 to 1.8.1 broke their build.
> The error: {code}
> [ERROR] Failed to execute goal org.apache.avro:avro-maven-plugin:1.8.1:idl-protocol (schemas) ... 
> org.apache.avro.compiler.idl.ParseException: Encountered " "date" "date "" at line 23, column 14.
> [ERROR] Was expecting one of:
> [ERROR] <IDENTIFIER> ...
> [ERROR] "@" ...
> [ERROR] "`" ...
> [ERROR] -> [Help 1]
> {code}
> As it turns out they have a test idl that contains this:
> {code}
> @namespace("org.apache.parquet.avro")
> protocol Cars {
>     record Service {
>         long date;
>     }
> }
> {code}
> And this change AVRO-1684 turned the word 'date' into something different for the idl compiler.
> So changing the word 'date' into something else fixes the problem. 
> Yet I think this is an undesirable effect for end user applications.
> [~rdblue]: I assigned this to you implemented the mentioned change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)