You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2017/01/08 07:44:48 UTC
Review Request 55318: Used loop in PollSocketImpl.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55318/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Used loop in PollSocketImpl.
Diffs
-----
3rdparty/libprocess/src/poll_socket.cpp 93ca37f105527fb225574107480114ee5ac74c76
Diff: https://reviews.apache.org/r/55318/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 55318: Used loop in PollSocketImpl.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55318/#review182134
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Jan. 8, 2017, 7:44 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55318/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2017, 7:44 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used loop in PollSocketImpl.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/poll_socket.cpp 5410b07e7b2ba5de4c1b61f358b6bcb224012eda
>
>
> Diff: https://reviews.apache.org/r/55318/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 55318: Used loop in PollSocketImpl.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55318/#review181640
-----------------------------------------------------------
3rdparty/libprocess/src/poll_socket.cpp
Lines 192-197 (original), 198-203 (patched)
<https://reviews.apache.org/r/55318/#comment257266>
Hm.. what happened here? Previously we treat is_restartable as being interrupted, and we don't trip back through poll, but in your change, we treat it the same as retryable and we trip back through poll. This distinction is lost in your change, was this intentional?
3rdparty/libprocess/src/poll_socket.cpp
Lines 239-257 (original), 244-248 (patched)
<https://reviews.apache.org/r/55318/#comment257267>
Ditto here.
- Benjamin Mahler
On Jan. 8, 2017, 7:44 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55318/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2017, 7:44 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used loop in PollSocketImpl.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/poll_socket.cpp 5410b07e7b2ba5de4c1b61f358b6bcb224012eda
>
>
> Diff: https://reviews.apache.org/r/55318/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>