You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/09/18 16:34:38 UTC
[PR] [SPARK-59641][K8S] Redact `spark.exit-exception` annotation with `spark.redaction.string.regex` [spark]
dongjoon-hyun opened a new pull request, #58911:
URL: https://github.com/apache/spark/pull/58911
### What changes were proposed in this pull request?
This PR aims to redact the exit exception annotation, `spark.exit-exception`, with `spark.redaction.string.regex` when `spark.kubernetes.driver.annotateExitException` is enabled.
In addition, this PR documents the following.
- The annotation is visible to anyone who can get the driver pod.
- `spark.redaction.string.regex` is used for the exit exception annotation on Kubernetes.
### Why are the changes needed?
`spark.kubernetes.driver.annotateExitException` (SPARK-53335) stores the stringified exit exception into the driver pod annotation without any redaction. Since an exception message may contain sensitive information like JDBC URLs, it is visible to anyone who can get the driver pod.
`spark.redaction.string.regex` is the existing configuration to redact the strings produced by Spark, like the output of SQL explain commands. This PR reuses it so that users can hide the sensitive parts of the exit exception without a new configuration.
### Does this PR introduce _any_ user-facing change?
No behavior change by default because `spark.redaction.string.regex` has no default value. If a user sets `spark.redaction.string.regex`, the matching parts of the `spark.exit-exception` annotation are replaced with `*********(redacted)`.
### How was this patch tested?
Pass the CIs with the newly added test case.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59641][K8S] Redact `spark.exit-exception` annotation with `spark.redaction.string.regex` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58911:
URL: https://github.com/apache/spark/pull/58911#issuecomment-5735752306
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/6aa2688a21e3fbc9db9abc2a66e47a951fa94702
- merged into branch-4.x https://github.com/apache/spark/commit/41e61d9f0412b89d412898588c43a7379d2ecf48
- merged into branch-4.3 https://github.com/apache/spark/commit/cde8720ff402b3dfca5f2758be0f108a68a3416b
- merged into branch-4.2 https://github.com/apache/spark/commit/e848706aba8d1fcf77eed8d668869ac6eec72300
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59641][K8S] Redact `spark.exit-exception` annotation with `spark.redaction.string.regex` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58911:
URL: https://github.com/apache/spark/pull/58911#issuecomment-5733189012
Thank you, @ForVic .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59641][K8S] Redact `spark.exit-exception` annotation with `spark.redaction.string.regex` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58911:
URL: https://github.com/apache/spark/pull/58911#issuecomment-5737215272
I backported this to branch-4.1 too.
- a0c8b5caebbd81279917410392800270f0b9d141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59641][K8S] Redact `spark.exit-exception` annotation with `spark.redaction.string.regex` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58911:
URL: https://github.com/apache/spark/pull/58911#issuecomment-5733076968
cc @ForVic , @sunchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59641][K8S] Redact `spark.exit-exception` annotation with `spark.redaction.string.regex` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58911:
URL: https://github.com/apache/spark/pull/58911#issuecomment-5734056709
Thank you, @sunchao !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59641][K8S] Redact `spark.exit-exception` annotation with `spark.redaction.string.regex` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #58911: [SPARK-59641][K8S] Redact `spark.exit-exception` annotation with `spark.redaction.string.regex`
URL: https://github.com/apache/spark/pull/58911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org