[jira] [Commented] (THRIFT-2327) nodejs: nodejs test suite should be bundled with the library

["Roger Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877222#comment-13877222 ] 

Roger Meier commented on THRIFT-2327:
-------------------------------------

thanks for this great work!

here are some comments:
 * *make check* needs to check *all languages*, java needs internet connection to load all the dependencies via maven as well. so we have to keep Makefile.am
 * test/test.sh is the cross language test suite, please ensure that this thing is working again with nodejs (e.g. nodejs-cpp, cpp-nodejs)
 * with the new commander.js it might be possible to do similar tests as with cpp or java within test/test.sh

Thanks!
roger


> nodejs: nodejs test suite should be bundled with the library
> ------------------------------------------------------------
>
>                 Key: THRIFT-2327
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2327
>             Project: Thrift
>          Issue Type: Test
>          Components: Node.js - Library
>    Affects Versions: 0.9.2
>            Reporter: Pierre Lamot
>            Priority: Minor
>         Attachments: 0001-THRIFT-2327-nodejs-nodejs-test-suite-should-be-bundl.patch
>
>
> as discussed in  THRIFT-2205, this issue is about moving node test suite to nodejs library folder and unifying tests (taking configuration from command line and testing each kind of protocol/transport configurations)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)