You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/05/14 23:27:12 UTC
Review Request 21460: Removed trailing / from /api end point.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
Removing the /, re-enables the gzip encryption.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061
Diff: https://reviews.apache.org/r/21460/diff/
Testing
-------
Tested on laptop.
Thanks,
Suman Karumuri
Re: Review Request 21460: Removed trailing / from /api end point.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/#review43026
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On May 14, 2014, 2:27 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21460/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 2:27 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
>
> Removing the /, re-enables the gzip encryption.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061
>
> Diff: https://reviews.apache.org/r/21460/diff/
>
>
> Testing
> -------
>
> Tested on laptop.
>
>
> File Attachments
> ----------------
>
> gzip encoded /api end point
> https://reviews.apache.org/media/uploaded/files/2014/05/14/2ea6ea61-0740-491c-a016-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21460: Removed trailing / from /api end point.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/#review43031
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java
<https://reviews.apache.org/r/21460/#comment77027>
I believe you're going to want to filter both /api and /api/* in two separate statements.
- Kevin Sweeney
On May 14, 2014, 2:42 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21460/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 2:42 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
>
> Removing the /, re-enables the gzip encryption.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061
>
> Diff: https://reviews.apache.org/r/21460/diff/
>
>
> Testing
> -------
>
> Tested on laptop.
>
>
> File Attachments
> ----------------
>
> gzip encoded /api end point
> https://reviews.apache.org/media/uploaded/files/2014/05/14/2ea6ea61-0740-491c-a016-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
> Enabled gzip encoding for /api/ end point.
> https://reviews.apache.org/media/uploaded/files/2014/05/14/637c4f85-7d22-49c1-89fc-7fea74f36b29__Screen_Shot_2014-05-14_at_2.37.49_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21460: Removed trailing / from /api end point.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/#review43035
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 14, 2014, 9:42 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21460/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 9:42 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
>
> Removing the /, re-enables the gzip encryption.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061
>
> Diff: https://reviews.apache.org/r/21460/diff/
>
>
> Testing
> -------
>
> Tested on laptop.
>
>
> File Attachments
> ----------------
>
> gzip encoded /api end point
> https://reviews.apache.org/media/uploaded/files/2014/05/14/2ea6ea61-0740-491c-a016-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
> Enabled gzip encoding for /api/ end point.
> https://reviews.apache.org/media/uploaded/files/2014/05/14/637c4f85-7d22-49c1-89fc-7fea74f36b29__Screen_Shot_2014-05-14_at_2.37.49_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21460: Removed trailing / from /api end point.
Posted by Suman Karumuri <ma...@apache.org>.
> On May 14, 2014, 9:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java, line 42
> > <https://reviews.apache.org/r/21460/diff/2/?file=581941#file581941line42>
> >
> > You definitely don't need two lines, since this is a servlet URL pattern. If Suman observed this working, i'm willing to trust him.
> >
> > I always seem to have trouble finding canonical docs on servlet URL patterns, but here's something: http://www.roguewave.com/portals/0/products/hydraexpress/docs/3.5.0/html/rwsfservletug/4-3.html
I can see this working but I wanted to be sure that I understood the url mapping right. Found the canonical docs:
https://java.net/downloads/servlet-spec/Final/servlet-3_1-final-change-bar.pdf
Chapter 12, page 123.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/#review43034
-----------------------------------------------------------
On May 14, 2014, 9:42 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21460/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 9:42 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
>
> Removing the /, re-enables the gzip encryption.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061
>
> Diff: https://reviews.apache.org/r/21460/diff/
>
>
> Testing
> -------
>
> Tested on laptop.
>
>
> File Attachments
> ----------------
>
> gzip encoded /api end point
> https://reviews.apache.org/media/uploaded/files/2014/05/14/2ea6ea61-0740-491c-a016-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
> Enabled gzip encoding for /api/ end point.
> https://reviews.apache.org/media/uploaded/files/2014/05/14/637c4f85-7d22-49c1-89fc-7fea74f36b29__Screen_Shot_2014-05-14_at_2.37.49_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21460: Removed trailing / from /api end point.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/#review43034
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java
<https://reviews.apache.org/r/21460/#comment77029>
You definitely don't need two lines, since this is a servlet URL pattern. If Suman observed this working, i'm willing to trust him.
I always seem to have trouble finding canonical docs on servlet URL patterns, but here's something: http://www.roguewave.com/portals/0/products/hydraexpress/docs/3.5.0/html/rwsfservletug/4-3.html
- Bill Farner
On May 14, 2014, 9:42 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21460/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 9:42 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
>
> Removing the /, re-enables the gzip encryption.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061
>
> Diff: https://reviews.apache.org/r/21460/diff/
>
>
> Testing
> -------
>
> Tested on laptop.
>
>
> File Attachments
> ----------------
>
> gzip encoded /api end point
> https://reviews.apache.org/media/uploaded/files/2014/05/14/2ea6ea61-0740-491c-a016-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
> Enabled gzip encoding for /api/ end point.
> https://reviews.apache.org/media/uploaded/files/2014/05/14/637c4f85-7d22-49c1-89fc-7fea74f36b29__Screen_Shot_2014-05-14_at_2.37.49_PM.png
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21460: Removed trailing / from /api end point.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/
-----------------------------------------------------------
(Updated May 14, 2014, 9:42 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
Because of a feature/bug in our Http Registration framework, we can't 404 on /api/ but serve /api. Since users can still query on /api/* and will receive a uncompressed response which can cause subtle page load issues that can be hard to detect. So, adding gzip encoding to /api/* also.
Repository: aurora
Description
-------
Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
Removing the /, re-enables the gzip encryption.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061
Diff: https://reviews.apache.org/r/21460/diff/
Testing
-------
Tested on laptop.
File Attachments (updated)
----------------
gzip encoded /api end point
https://reviews.apache.org/media/uploaded/files/2014/05/14/2ea6ea61-0740-491c-a016-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
Enabled gzip encoding for /api/ end point.
https://reviews.apache.org/media/uploaded/files/2014/05/14/637c4f85-7d22-49c1-89fc-7fea74f36b29__Screen_Shot_2014-05-14_at_2.37.49_PM.png
Thanks,
Suman Karumuri
Re: Review Request 21460: Removed trailing / from /api end point.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/
-----------------------------------------------------------
(Updated May 14, 2014, 9:27 p.m.)
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
Removing the /, re-enables the gzip encryption.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061
Diff: https://reviews.apache.org/r/21460/diff/
Testing
-------
Tested on laptop.
File Attachments (updated)
----------------
gzip encoded /api end point
https://reviews.apache.org/media/uploaded/files/2014/05/14/2ea6ea61-0740-491c-a016-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
Thanks,
Suman Karumuri