You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/12/08 01:17:22 UTC
[GitHub] [trafficserver] masaori335 opened a new pull request #8549: Relax key validation of sni.yaml
masaori335 opened a new pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549
For the forward compatibility of new keys.
## Background
When ATS reads the `sni.yaml` file, it checks the keys of the yaml. This is a bit annoying when you deploy a new key to the env which has old and new versions of ATS.
IMO, just ignoring "unknown keys" is fine. Because the function touches the node by defined keys. Any concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 removed a comment on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993180527
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993082718
Please take another look.
1. Change log level to the `Warning`
2. Add the "SNI config" in the message. Because it's a bit tricky to get the sni config file name from this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-1006048192
Cherry-picked to v9.1.x branch.
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993180527
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993114388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993084028
> Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post http://%2Fvar%2Frun%2Fdocker.sock/v1.24/images/create?fromImage=controller.trafficserver.org%2Fats%2Fcentos&tag=8: dial unix /var/run/docker.sock: connect: permission denied
hmm, something wrong with the ci system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993114379
[approve ci fedora]
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-995343502
All green, it's ready!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 merged pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 merged pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993115414
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993025740
A potential problem is that you misspell a key for which there is a default value. Then you are running with the default value and will see no problem indication in diags.log. Should we use Warning instead of Note?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993115414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 edited a comment on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 edited a comment on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993082718
Please take another look. I followed the advice we talked about at the weekly bug scrab.
1. Change log level to the `Warning`
2. Add the "SNI config" in the message. Because it's a bit tricky to get the sni config file name from this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 removed a comment on pull request #8549: Relax key validation of sni.yaml
Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #8549:
URL: https://github.com/apache/trafficserver/pull/8549#issuecomment-993114379
[approve ci fedora]
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org