You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/03/30 12:25:32 UTC

[GitHub] [echarts] baojd42 opened a new pull request #14560: feat(line): support brushSelector for lineSeries. close #6718

baojd42 opened a new pull request #14560:
URL: https://github.com/apache/echarts/pull/14560


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   Add brushSelector for lineSeries, so that dataIndex can be selected when line series are brushed.
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   #6718
   #10739
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   No dataIndex was selected when line series are burshed.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   DataIndex can be selected when line series are brushed
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] yedongze commented on pull request #14560: feat(line): support brushSelector for lineSeries. close #6718

Posted by GitBox <gi...@apache.org>.
yedongze commented on pull request #14560:
URL: https://github.com/apache/echarts/pull/14560#issuecomment-981344004


   mark


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14560: feat(line): support brushSelector for lineSeries. close #6718

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14560:
URL: https://github.com/apache/echarts/pull/14560#issuecomment-810178800


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia commented on pull request #14560: feat(line): support brushSelector for lineSeries. close #6718

Posted by GitBox <gi...@apache.org>.
Ovilia commented on pull request #14560:
URL: https://github.com/apache/echarts/pull/14560#issuecomment-813988033


   Thanks for your contribution!
   
   This PR seems to work for the data items of line series, but not the lines. I think in order to have the same behavior of other series like bars, the lines out-of-range should be set to be out of range.
   @pissang or @100pah will give you a further CR and advice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] baojd42 closed pull request #14560: feat(line): support brushSelector for lineSeries. close #6718

Posted by GitBox <gi...@apache.org>.
baojd42 closed pull request #14560:
URL: https://github.com/apache/echarts/pull/14560


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org