You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/11 08:55:47 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #4970: [INLONG-4939][Manager] Add version control for all the save and update APIs
fuweng11 opened a new pull request, #4970:
URL: https://github.com/apache/inlong/pull/4970
- Title Example: [INLONG-4939][Manager] Add version control for all the save and update APIs
- Fixes #4939
### Motivation
Add version control to prevent concurrent modification problems
### Modifications
Add a version field to multiple tables（inlong_group, inlong_stream, consumption, user, inlong_cluster, etc）
Verify the version number when modifying the above table
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [X] This change is already covered by existing tests, such as:
*(please describe tests)*
org.apache.inlong.manager.service.core.impl.DataNodeServiceTest
org.apache.inlong.manager.service.workflow.WorkflowServiceImplTest
- [ ] This change added tests and can be verified as follows:
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #4970: [INLONG-4939][Manager] Add version control for all the save and update APIs
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4970:
URL: https://github.com/apache/inlong/pull/4970#discussion_r927269852
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -65,6 +65,8 @@
public class StreamSinkServiceImpl implements StreamSinkService {
private static final Logger LOGGER = LoggerFactory.getLogger(StreamSinkServiceImpl.class);
+ private static final Integer UPDATE_SUCCESS = 1;
Review Comment:
This constant can extract as a global constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #4970: [INLONG-4939][Manager] Add version control for all the save and update APIs
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4970:
URL: https://github.com/apache/inlong/pull/4970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org