You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/01/14 15:26:10 UTC
Review Request 42305: Updated comments around sorters in the
allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42305/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Bugs: MESOS-4128
https://issues.apache.org/jira/browse/MESOS-4128
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 5f08b6e7d18766d7d0f8350a280ec577b4895fb9
Diff: https://reviews.apache.org/r/42305/diff/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 42305: Updated comments around sorters in the
allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Jan. 16, 2016, 11:09 p.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 412
> > <https://reviews.apache.org/r/42305/diff/2/?file=1196926#file1196926line412>
> >
> > I think you mean `Level 1`?
Correct, sorry!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42305/#review114890
-----------------------------------------------------------
On Jan. 14, 2016, 3:39 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42305/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 3:39 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-4128
> https://issues.apache.org/jira/browse/MESOS-4128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 5f08b6e7d18766d7d0f8350a280ec577b4895fb9
>
> Diff: https://reviews.apache.org/r/42305/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42305: Updated comments around sorters in the
allocator.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42305/#review114890
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.hpp (line 409)
<https://reviews.apache.org/r/42305/#comment175722>
I think you mean `Level 1`?
- Joris Van Remoortere
On Jan. 14, 2016, 3:39 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42305/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 3:39 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-4128
> https://issues.apache.org/jira/browse/MESOS-4128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 5f08b6e7d18766d7d0f8350a280ec577b4895fb9
>
> Diff: https://reviews.apache.org/r/42305/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42305: Updated comments around sorters in the
allocator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42305/#review114506
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42221, 42222, 42305]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 14, 2016, 3:39 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42305/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 3:39 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-4128
> https://issues.apache.org/jira/browse/MESOS-4128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 5f08b6e7d18766d7d0f8350a280ec577b4895fb9
>
> Diff: https://reviews.apache.org/r/42305/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42305: Updated comments around sorters in the
allocator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42305/#review114648
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (line 388)
<https://reviews.apache.org/r/42305/#comment175511>
Can you please add more detail for `remaining resources`? It would be great if we can clarify that the `remaining resources` do not include resources which are reserved by Quota but not allocated.
- Guangya Liu
On 一月 14, 2016, 3:39 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42305/
> -----------------------------------------------------------
>
> (Updated 一月 14, 2016, 3:39 p.m.)
>
>
> Review request for mesos, Ben Mahler and Joris Van Remoortere.
>
>
> Bugs: MESOS-4128
> https://issues.apache.org/jira/browse/MESOS-4128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 5f08b6e7d18766d7d0f8350a280ec577b4895fb9
>
> Diff: https://reviews.apache.org/r/42305/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 42305: Updated comments around sorters in the
allocator.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42305/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 3:39 p.m.)
Review request for mesos, Ben Mahler and Joris Van Remoortere.
Changes
-------
Fixed a compilation issue.
Bugs: MESOS-4128
https://issues.apache.org/jira/browse/MESOS-4128
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 5f08b6e7d18766d7d0f8350a280ec577b4895fb9
Diff: https://reviews.apache.org/r/42305/diff/
Testing (updated)
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov