You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/03 17:35:19 UTC

[GitHub] [shardingsphere] menghaoranss opened a new pull request #5911: Fixes faild to disable slave database through ui #dev-4.x

menghaoranss opened a new pull request #5911:
URL: https://github.com/apache/shardingsphere/pull/5911


   Fixes #5899.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #5911: Fixes faild to disable slave database through ui #dev-4.x

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5911:
URL: https://github.com/apache/shardingsphere/pull/5911#issuecomment-638396415


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5911?src=pr&el=h1) Report
   > Merging [#5911](https://codecov.io/gh/apache/shardingsphere/pull/5911?src=pr&el=desc) into [dev-4.x](https://codecov.io/gh/apache/shardingsphere/commit/da283c2fee891e6970442a1ccdc82b7556f89c7d&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `40.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5911/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5911?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             dev-4.x    #5911      +/-   ##
   =============================================
   - Coverage      53.62%   53.61%   -0.02%     
   + Complexity       387      386       -1     
   =============================================
     Files           1147     1147              
     Lines          20466    20468       +2     
     Branches        3728     3729       +1     
   =============================================
   - Hits           10975    10974       -1     
   - Misses          8804     8805       +1     
   - Partials         687      689       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5911?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rchestration/center/listener/DataChangedEvent.java](https://codecov.io/gh/apache/shardingsphere/pull/5911/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2xpc3RlbmVyL0RhdGFDaGFuZ2VkRXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...enter/listener/DataSourceStateChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/5911/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvbGlzdGVuZXIvRGF0YVNvdXJjZVN0YXRlQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `62.50% <0.00%> (-8.93%)` | `0.00 <0.00> (ø)` | |
   | [...ter/instance/CuratorZookeeperCenterRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/5911/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckNlbnRlclJlcG9zaXRvcnkuamF2YQ==) | `64.28% <100.00%> (-1.49%)` | `23.00 <0.00> (-1.00)` | |
   | [...rycenter/listener/StateChangedListenerManager.java](https://codecov.io/gh/apache/shardingsphere/pull/5911/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvbGlzdGVuZXIvU3RhdGVDaGFuZ2VkTGlzdGVuZXJNYW5hZ2VyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5911?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5911?src=pr&el=footer). Last update [da283c2...c65122a](https://codecov.io/gh/apache/shardingsphere/pull/5911?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] kimmking merged pull request #5911: Fixes faild to disable slave database through ui #dev-4.x

Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #5911:
URL: https://github.com/apache/shardingsphere/pull/5911


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] coveralls commented on pull request #5911: Fixes faild to disable slave database through ui #dev-4.x

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5911:
URL: https://github.com/apache/shardingsphere/pull/5911#issuecomment-638402873


   ## Pull Request Test Coverage Report for [Build 12263](https://coveralls.io/builds/31219836)
   
   * **4** of **5**   **(80.0%)**  changed or added relevant lines in **4** files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage decreased (**-0.0007%**) to **57.04%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-api/src/main/java/org/apache/shardingsphere/orchestration/center/listener/DataChangedEvent.java](https://coveralls.io/builds/31219836/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Flistener%2FDataChangedEvent.java#L41) | 0 | 1 | 0.0%
   <!-- | **Total:** | **4** | **5** | **80.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java](https://coveralls.io/builds/31219836/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FCuratorZookeeperCenterRepository.java#L239) | 1 | 71.43% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/31219836/badge)](https://coveralls.io/builds/31219836) |
   | :-- | --: |
   | Change from base [Build 12256](https://coveralls.io/builds/31214178): |  -0.0007% |
   | Covered Lines: | 11675 |
   | Relevant Lines: | 20468 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org