[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30483: [SPARK-33449][SQL] Add File Metadata cache support for Parquet and Orc

[GitBox <gi...@apache.org>]

dongjoon-hyun edited a comment on pull request #30483:
URL: https://github.com/apache/spark/pull/30483#issuecomment-899089526


   I've looking around the code. The most serious block is the following because both Apache Spark and Parquet community are reluctant to advertise the deprecated API. So, my suggestion here is to split this PR into two PRs. (Parquet PR and ORC PR). For Parquet PR, let's reuse this one because this has all your code. In other words, can you spin off ORC-only PR?
   
   > Parquet no longer has non Deprecated API that can be used to pass footer to create new ParquetFileReader
   
   In a new ORC PR description, you can give a link to this whole PR to explain why we handle Parquet/ORC seperately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org