[GitHub] [gobblin] ZihanLi58 commented on a change in pull request #3475: [GOBBLIN-1617] pass configurations to some HadoopUtils APIs

[GitBox <gi...@apache.org>]

ZihanLi58 commented on a change in pull request #3475:
URL: https://github.com/apache/gobblin/pull/3475#discussion_r821008909



##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/HadoopUtils.java
##########
@@ -262,11 +268,15 @@ public static void renamePath(FileSystem fs, Path oldName, Path newName) throws
     renamePath(fs, oldName, newName, false);
   }
 
+  public static void renamePath(FileSystem fs, Path oldName, Path newName, boolean overwrite) throws IOException {

Review comment:
       Same here as it's public static method

##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/HadoopUtils.java
##########
@@ -203,16 +203,22 @@ public static void deletePathByRegex(FileSystem fs, final Path path, final Strin
     }
   }
 
+  public static void moveToTrash(FileSystem fs, Path path) throws IOException {

Review comment:
       Add comments to this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org