You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2015/05/07 14:50:13 UTC

[GitHub] flink pull request: [hotfix][scala] Let type analysis work on some...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/660

    [hotfix][scala] Let type analysis work on some Java types

    This is mostly to allow Vertex, which is a Java Tuple2<> to be used in
    the Scala Gelly API.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink scala-type-analysis-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #660
    
----
commit 6c382dccc6ddc825f348aa9dc91bf64d857f400e
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2015-05-07T12:27:33Z

    [hotfix][scala] Let type analysis work on some Java types
    
    This is mostly to allow Vertex, which is a Java Tuple2<> to be used in
    the Scala Gelly API.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [hotfix][scala] Let type analysis work on some...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/660#issuecomment-101190844
  
    How hard is it to add Java Tuple support to the Scala API? May be also interesting for people that want to use mutable tuples in Scala...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [hotfix][scala] Let type analysis work on some...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/660#issuecomment-101145293
  
    It does not treat Java classes the same. For some strange reason, the Scala Type analysis in Scala 2.10 can sometimes not "see" the fields of classes defined in Java.
    
    The Scala Type analysis treats Java Tuples as what they are, POJOs. We could maybe add special case handling to make it treat Java tuples as Java tuples.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [hotfix][scala] Let type analysis work on some...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/660#issuecomment-101199537
  
    See here: https://github.com/apache/flink/pull/669


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [hotfix][scala] Let type analysis work on some...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:

    https://github.com/apache/flink/pull/660


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [hotfix][scala] Let type analysis work on some...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/660#issuecomment-100999172
  
    Seems to contain a second fix, to skip static fields in data types.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [hotfix][scala] Let type analysis work on some...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/660#issuecomment-101000540
  
    Does the Scala API not treat Java classes the same way as its own classes?
    That sounds absolutely like the right thing to do. Why not do as much compile time analysis as possible...
    
    To understand this better, does the Scala type analysis now generate
     - Java Tuple TypeInformation?
     - Does it treat Java POJOs as POJO types?
     - ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---