You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/07/29 07:08:30 UTC

[Impala-ASF-CR] IMPALA-11401,IMPALA-10794: Add logs and thread names for catalogd RPCs

Hello Tamas Mate, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18772

to look at the new patch set (#2).

Change subject: IMPALA-11401,IMPALA-10794: Add logs and thread names for catalogd RPCs
......................................................................

IMPALA-11401,IMPALA-10794: Add logs and thread names for catalogd RPCs

We've seen catalogd throws OutOfMemoryError when serializing large
responses (i.e. size > 2GB). However, the related table names are
missing in the logs. Admins would like to get the table names and
blacklist those tables until they are optimized (e.g. reducing
partitions).

To improve the supportability, this patch adds logs in the Catalogd RPC
code paths to log some details of the request, also add thread
annotations to improve readability of jstacks.

Tests:
 - Add unit tests for short descriptions of requests.
 - Manually add codes to throw OutOfMemoryError and verify the logs
   shown as expected.
 - Run test_concurrent_ddls.py and capture jstacks. Verify the thread
   annotations are shown.

Change-Id: Iac7f2eda8b95643a3d3c3bef64ea71b67b20595a
---
M fe/src/main/java/org/apache/impala/analysis/FunctionName.java
M fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java
M fe/src/main/java/org/apache/impala/analysis/TableName.java
M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
A fe/src/main/java/org/apache/impala/util/CatalogOpUtil.java
A fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java
8 files changed, 431 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/18772/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac7f2eda8b95643a3d3c3bef64ea71b67b20595a
Gerrit-Change-Number: 18772
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>